linux-kernel - Re: [PATCH 18/26] rv/rvgen: add fill_tracepoint_args

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c866db81d6213862baf4a4d3d9f2f013b7ef058b.camel@redhat.com>
Date: Fri, 23 Jan 2026 13:26:45 +0100
From: Gabriele Monaco <gmonaco@...hat.com>
To: Wander Lairson Costa <wander@...hat.com>
Cc: Steven Rostedt <rostedt@...dmis.org>, Nam Cao <namcao@...utronix.de>, 
 open list <linux-kernel@...r.kernel.org>, "open list:RUNTIME VERIFICATION
 (RV)"	 <linux-trace-kernel@...r.kernel.org>
Subject: Re: [PATCH 18/26] rv/rvgen: add fill_tracepoint_args_skel stub to
 ltl2k

On Fri, 2026-01-23 at 09:19 -0300, Wander Lairson Costa wrote:
> On Thu, Jan 22, 2026 at 02:49:59PM +0100, Gabriele Monaco wrote:
> > Why fill_tracepoint_args_skel() is not required by LTL is an implementation
> > detail, so that stub could even stay, in case future monitors are going to
> > need
> > the entire thing.
> > Though I still find it cleaner to move that away too until there's a need
> > for it
> > shared in Monitor.
> 
> I didn't catch what is included in "that"...

Right, it ended up quite cryptic, I meant fill_tracepoint_args_skel() could stay
in Monitor although not all Monitors need it, though I honestly prefer to move
it away and not rely on the stub. 

> > What do you think?
> 
> I agreed. fill_tracepoint_args_skel() makes sense in the Monitor class.
> If a derived class doesn't need it, it is an implementation detail.
> 

But I get your stance and agree with that too, where fill_tracepoint_args_skel()
goes is just nitpicking at this point.

Thanks,
Gabriele