linux-kernel - Re: [PATCH 2/2] riscv: dts: spacemit: add fixed regulators for OrangePi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260123145015.1926865-1-amadeus@jmu.edu.cn>
Date: Fri, 23 Jan 2026 22:50:15 +0800
From: Chukun Pan <amadeus@....edu.cn>
To: dlan@...too.org
Cc: alex@...ti.fr,
	amadeus@....edu.cn,
	aou@...s.berkeley.edu,
	conor+dt@...nel.org,
	krzk+dt@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org,
	palmer@...belt.com,
	pjw@...nel.org,
	robh@...nel.org,
	spacemit@...ts.linux.dev
Subject: Re: [PATCH 2/2] riscv: dts: spacemit: add fixed regulators for OrangePi

Hi,

> > +	pcie_vcc3v3: regulator-pcie-vcc3v3 {
> can you follow the same name scheme with k1-bananapi-f3.dts?

Sorry, but I don't quite understand?

>From fixed-regulator.yaml:
properties:
  $nodename:
    anyOf:
      - description: Preferred name is 'regulator-[0-9]v[0-9]'
        pattern: '^regulator(-[0-9]+v[0-9]+|-[0-9a-z-]+)?$'
      - description: Any name allowed
        deprecated: true

Using 'regulator-' as a prefix is correct.
There are also some commits that changed regulator nodenames. [1]

As for the regulator-name, it should be consistent with the name in
the schematics so that people can look it up between the two.
The BPI-F3 also seems to have some names [2] that need improvement:

vcc_4v     -> vcc4v0_sys
USB30_HUB  -> vcc5v0_hub
USB30_VBUS -> 5v_vbus
vin-supply    vcc5v0_sys

> also please add this regulator with explict consumer - pcie,
> otherwise I see the patch isn't really useful

I will update this in the next version.

[1] https://github.com/torvalds/linux/commit/5c96e63301978f4657c9082c55a066763c8db7b1
[2] https://drive.google.com/file/d/19iLJ5xnCB_oK8VeQjkPGjzAn39WYyylv/view?usp=sharing

Thanks,
Chukun