linux-kernel - Re: [PATCH 19/21] iio: Use IRQF_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXOK0vqIQbCAw7mx@smile.fi.intel.com>
Date: Fri, 23 Jan 2026 16:50:58 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc: linux-kernel@...r.kernel.org, linux-rt-devel@...ts.linux.dev,
	Thomas Gleixner <tglx@...nel.org>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	linux-iio@...r.kernel.org
Subject: Re: [PATCH 19/21] iio: Use IRQF_NO_THREAD

On Fri, Jan 23, 2026 at 12:37:05PM +0100, Sebastian Andrzej Siewior wrote:
> The interrupt handler iio_trigger_generic_data_rdy_poll() will invoke
> other interrupt handler and this supposed to happen from within the
> hardirq.
> 
> Use IRQF_NO_THREAD to forbid forced-threading.

...

> Cc: Jonathan Cameron <jic23@...nel.org>
> Cc: David Lechner <dlechner@...libre.com>
> Cc: "Nuno Sá" <nuno.sa@...log.com>
> Cc: Andy Shevchenko <andy@...nel.org>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Michael Hennerich <Michael.Hennerich@...log.com>
> Cc: linux-iio@...r.kernel.org

Same comment about Cc list.

...

>  	ret = request_irq(st->i2c->irq,
>  			  &iio_trigger_generic_data_rdy_poll,
> -			  IRQF_TRIGGER_RISING,
> +			  IRQF_NO_THREAD | IRQF_TRIGGER_RISING,

Maybe swap their positions as it's done everywhere else for the consistency's
sake?

>  			  "itg3200_data_rdy",
>  			  st->trig);

-- 
With Best Regards,
Andy Shevchenko