linux-kernel - Re: [PATCH V3 2/5] mm/khugepaged: count small VMAs towards scan limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260123073738.76b9e59521270e45eae70f88@linux-foundation.org>
Date: Fri, 23 Jan 2026 07:37:38 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Garg, Shivank" <shivankg@....com>
Cc: Zi Yan <ziy@...dia.com>, Baolin Wang <baolin.wang@...ux.alibaba.com>,
 "Liam R . Howlett" <Liam.Howlett@...cle.com>, Nico Pache
 <npache@...hat.com>, David Hildenbrand <david@...nel.org>, Ryan Roberts
 <ryan.roberts@....com>, Barry Song <baohua@...nel.org>, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, Wei Yang <richard.weiyang@...il.com>, Lorenzo
 Stoakes <lorenzo.stoakes@...cle.com>
Subject: Re: [PATCH V3 2/5] mm/khugepaged: count small VMAs towards scan
 limit

On Fri, 23 Jan 2026 16:12:07 +0530 "Garg, Shivank" <shivankg@....com> wrote:

> >> I was worrying about a case that doesn't actually happen.
> >>
> > You're right, thp_vma_allowable_order() is taking care of this, making 
> > hend <= hstart check redundant.
> > 
> > Thank you for catching this.
> > 
> > I'll drop this change and send revision keeping only the unsigned int type 
> > change for 'progress'.
> > 
> 
> Hi Andrew,
> 
> Please drop this patch.

thud.

> As Dev and Lance noted that the hend <= hstart handling check is redundant.
> 
> The 'progress' variable to unsigned int is not critical either.

OK.

Were you thinking of adopting Dev's suggestion? 
https://lkml.kernel.org/r/6486c6dd-2702-4a4d-9662-09639532ce6f@arm.com.

If so, let's defer until the next cycle, please.  Now is the time to be
focusing on stabilization, test, finishing up review, etc.