linux-kernel - Re: [PATCH 2/3] usb: gadget: f_mass_storage: Add a prefix to log messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fd83508-5985-44fc-ae26-2960d575df9e@rowland.harvard.edu>
Date: Fri, 23 Jan 2026 11:00:44 -0500
From: Alan Stern <stern@...land.harvard.edu>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] usb: gadget: f_mass_storage: Add a prefix to log
 messages

On Fri, Jan 23, 2026 at 10:22:20PM +0800, Jisheng Zhang wrote:
> Similar as last patch,

This is not a good thing to put in a patch description.  Once the patch 
has been merged into the kernel source, nobody will know what the "last 
patch" was -- it refers to something in a mailing list, not something 
available to people reading a changelog in Git.

Alan Stern

>  add a prefix to log messages so that users can
> convienently know where's the msg from.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...nel.org>
> ---
>  drivers/usb/gadget/function/f_mass_storage.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/gadget/function/f_mass_storage.c b/drivers/usb/gadget/function/f_mass_storage.c
> index 94d478b6bcd3..d7ae076705c4 100644
> --- a/drivers/usb/gadget/function/f_mass_storage.c
> +++ b/drivers/usb/gadget/function/f_mass_storage.c
> @@ -168,6 +168,8 @@
>  /* #define VERBOSE_DEBUG */
>  /* #define DUMP_MSGS */
>  
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
>  #include <linux/blkdev.h>
>  #include <linux/completion.h>
>  #include <linux/dcache.h>
> -- 
> 2.51.0
> 
>