linux-kernel - Re: [PATCH v2 1/2] i3c: dw-i3c-master: convert spinlock usage to scoped guards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aXOclWlrqu/9ucnw@lizhi-Precision-Tower-5810>
Date: Fri, 23 Jan 2026 11:06:45 -0500
From: Frank Li <Frank.li@....com>
To: adrianhoyin.ng@...era.com
Cc: alexandre.belloni@...tlin.com, linux-i3c@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] i3c: dw-i3c-master: convert spinlock usage to
 scoped guards

On Fri, Jan 23, 2026 at 03:35:11PM +0800, adrianhoyin.ng@...era.com wrote:
> From: Adrian Ng Ho Yin <adrianhoyin.ng@...era.com>
>
> Convert dw-i3c-master to use scoped spinlock guards in place of
> open-coded spin_lock_irqsave()/spin_unlock_irqrestore() pairs to ensure
> locks are always safely released on scope exit.
>
> Signed-off-by: Adrian Ng Ho Yin <adrianhoyin.ng@...era.com>
> ---
...
> @@ -1212,11 +1204,9 @@ static void dw_i3c_master_free_ibi(struct i3c_dev_desc *dev)
>  	struct dw_i3c_i2c_dev_data *data = i3c_dev_get_master_data(dev);
>  	struct i3c_master_controller *m = i3c_dev_get_master(dev);
>  	struct dw_i3c_master *master = to_dw_i3c_master(m);
> -	unsigned long flags;
>
> -	spin_lock_irqsave(&master->devs_lock, flags);
> +	guard(spinlock_irqsave)(&master->devs_lock);
>  	master->devs[data->index].ibi_dev = NULL;
> -	spin_unlock_irqrestore(&master->devs_lock, flags);

This one need use scope_guard(), otherwise below i3c_generic_ibi_free_pool()
will be in spin_lock protection.

Frank
>
>  	i3c_generic_ibi_free_pool(data->ibi_pool);
>  	data->ibi_pool = NULL;
> @@ -1243,13 +1233,12 @@ static void dw_i3c_master_set_sir_enabled(struct dw_i3c_master *master,
>  					  struct i3c_dev_desc *dev,
>  					  u8 idx, bool enable)
...
>
>  /* "ibis": referring to In-Band Interrupts, and not
> --
> 2.49.GIT
>