linux-kernel - Re: [PATCH bpf-next 2/2] selftests/bpf: Add test for connect() racing sockmap update and signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <45de7914fd90da6c4940d1c299282eb40d5921ab1f3b9953a120e59a7a9f907c@mail.kernel.org>
Date: Fri, 23 Jan 2026 17:09:29 +0000 (UTC)
From: bot+bpf-ci@...nel.org
To: mhal@...x.co,ast@...nel.org,daniel@...earbox.net,andrii@...nel.org,martin.lau@...ux.dev,eddyz87@...il.com,song@...nel.org,yonghong.song@...ux.dev,john.fastabend@...il.com,kpsingh@...nel.org,sdf@...ichev.me,haoluo@...gle.com,jolsa@...nel.org,shuah@...nel.org,kuniyu@...gle.com
Cc: bpf@...r.kernel.org,linux-kselftest@...r.kernel.org,linux-kernel@...r.kernel.org,mhal@...x.co,ast@...nel.org,andrii@...nel.org,daniel@...earbox.net,martin.lau@...nel.org,eddyz87@...il.com,yonghong.song@...ux.dev,clm@...a.com,ihor.solodrai@...ux.dev
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: Add test for connect() racing sockmap update and signal

> diff --git a/tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c b/tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c
> new file mode 100644
> index 000000000000..aa48ae483dab
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/prog_tests/sockmap_interrupted_connect.c
> @@ -0,0 +1,200 @@
> +// SPDX-License-Identifier: GPL-2.0

[ ... ]

> +#include "sockmap_helpers.h"

[ ... ]

> +void serial_test_sockmap_interrupted_connect(void)
> +{
> +	sighandler_t orig_handler;
> +	struct context ctx = {0};
> +	pthread_t tid;
> +
> +	orig_handler = signal(SIGUSR1, handler);
> +	if (!ASSERT_NEQ(orig_handler, SIG_ERR, "signal"))
> +		return;
> +
> +	if (xpthread_create(&tid, NULL, racer, &ctx))
> +		goto restore;
> +
> +	test_map(&ctx, BPF_MAP_TYPE_SOCKMAP);
> +
> +	if (!xpthread_cancel(tid))
              ^^^^^^^^^^^^^^^^

Is xpthread_cancel() defined somewhere? I see sockmap_helpers.h defines
xpthread_create() and xpthread_join(), but there does not appear to be a
definition for xpthread_cancel(). This would cause a compilation failure.

> +		xpthread_join(tid, NULL);
> +restore:
> +	ASSERT_NEQ(signal(SIGUSR1, orig_handler), SIG_ERR, "handler restore");
> +}


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21294285592