linux-kernel - Re: [PATCH v2] function_graph: Fix args pointer mismatch in print_graph

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260123121858.0f7c3e98@gandalf.local.home>
Date: Fri, 23 Jan 2026 12:18:58 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Donglin Peng <dolinux.peng@...il.com>
Cc: mhiramat@...nel.org, linux-trace-kernel@...r.kernel.org,
 linux-kernel@...r.kernel.org, Donglin Peng <pengdonglin@...omi.com>
Subject: Re: [PATCH v2] function_graph: Fix args pointer mismatch in
 print_graph_retval()

On Mon, 12 Jan 2026 10:16:01 +0800
Donglin Peng <dolinux.peng@...il.com> wrote:

> From: Donglin Peng <pengdonglin@...omi.com>
> 
> When funcgraph-args and funcgraph-retaddr are both enabled, many kernel
> functions display invalid parameters in trace logs[1].
> 
> The issue occurs because print_graph_retval() passes a mismatched args
> pointer to print_function_args(). Fix this by retrieving the correct
> args pointer using the FGRAPH_ENTRY_ARGS() macro.
> 
> [1] https://gitee.com/pengdonglin137/funcgraph_visualization/raw/master/samples/error_args.png

Please do not provide links to images. This stays in the git logs for the
lifetime of the Linux kernel. Images like this will likely not live as long
and the link becomes wasted space in the git history.

Either do a cut and paste of the bad output, or don't include it at all.

-- Steve


> Fixes: f83ac7544fbf ("function_graph: Enable funcgraph-args and funcgraph-retaddr to work simultaneously")
> Signed-off-by: Donglin Peng <pengdonglin@...omi.com>