linux-kernel - Re: [PATCH] perf annotate: Fix memcpy size in arch__grow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXOvUzI56ePokDd_@x1>
Date: Fri, 23 Jan 2026 14:26:43 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Suchit Karunakaran <suchitkarunakaran@...il.com>, mingo@...hat.com,
	namhyung@...nel.org, peterz@...radead.org, adrian.hunter@...el.com,
	alexander.shishkin@...ux.intel.com, james.clark@...aro.org,
	jolsa@...nel.org, mark.rutland@....com,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf annotate: Fix memcpy size in arch__grow_instructions

On Thu, Jan 22, 2026 at 10:27:27AM -0800, Ian Rogers wrote:
> On Thu, Jan 22, 2026 at 9:17 AM Suchit Karunakaran <suchitkarunakaran@...il.com> wrote:

> > The memcpy in arch__grow_instructions() is copying the wrong number of
> > bytes when growing from a non-allocated table. It should copy
> > arch->nr_instructions * sizeof(struct ins) bytes, not just
> > arch->nr_instructions bytes.

> > This bug causes data corruption as only a partial copy of the
> > instruction table is made, leading to garbage data in most entries and
> > potential crashes

> > Signed-off-by: Suchit Karunakaran <suchitkarunakaran@...il.com>
> > ---
> >  tools/perf/util/disasm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)

> > diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c
> > index 50b9433f3f8e..6faa9df8e373 100644
> > --- a/tools/perf/util/disasm.c
> > +++ b/tools/perf/util/disasm.c
> > @@ -81,7 +81,7 @@ static int arch__grow_instructions(struct arch *arch)
> >         if (new_instructions == NULL)
> >                 return -1;

> > -       memcpy(new_instructions, arch->instructions, arch->nr_instructions);
> > +       memcpy(new_instructions, arch->instructions, arch->nr_instructions * sizeof(struct ins));

> Reviewed-by: Ian Rogers <irogers@...gle.com>

> Nice catch! I think we've been trying to make code like this more like:
> memcpy(new_instructions, arch->instructions, arch->nr_instructions *
> sizeof(*new_instructions));
> but the immediately preceding calloc isn't doing this, so your patch
> is consistent. There is also a clean up in this code to switch to
> using reallocarray rather than realloc.

Right, that would be better, but the fix is good as is and we can
cleanup it later.

I added the missing:

Fixes: 2a1ff812c40be982 ("perf annotate: Introduce alternative method of keeping instructions table")

Its an old bug I introduced almost 10 years ago ;-\

- Arnaldo