linux-kernel - Re: [PATCH v2 1/1] ACPI: video: simplify code with acpi_get_local_u64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h-fZLG+4cqtPYYCRZrKqSXHMaaPuGx2UYBCMPY0+_0tg@mail.gmail.com>
Date: Fri, 23 Jan 2026 20:17:33 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>, linux-acpi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Len Brown <lenb@...nel.org>
Subject: Re: [PATCH v2 1/1] ACPI: video: simplify code with acpi_get_local_u64_address()

On Wed, Jan 21, 2026 at 9:47 AM Andy Shevchenko
<andriy.shevchenko@...ux.intel.com> wrote:
>
> Now we have a helper so there's no need to open-code.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>
> v2: removed now unused variable (LKP)
>
>  drivers/acpi/acpi_video.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
> index 944aba605c1a..69469757b965 100644
> --- a/drivers/acpi/acpi_video.c
> +++ b/drivers/acpi/acpi_video.c
> @@ -1134,13 +1134,11 @@ static int acpi_video_bus_get_one_device(struct acpi_device *device, void *arg)
>         struct acpi_video_bus *video = arg;
>         struct acpi_video_device_attrib *attribute;
>         struct acpi_video_device *data;
> -       unsigned long long device_id;
> -       acpi_status status;
>         int device_type;
> +       u64 device_id;
>
> -       status = acpi_evaluate_integer(device->handle, "_ADR", NULL, &device_id);
>         /* Skip devices without _ADR instead of failing. */
> -       if (ACPI_FAILURE(status))
> +       if (acpi_get_local_u64_address(device->handle, &device_id))
>                 goto exit;
>
>         data = kzalloc(sizeof(struct acpi_video_device), GFP_KERNEL);
> --

Applied as 6.20 material, thanks!