[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6441f33d-b4ac-4483-87c6-236998803338@nvidia.com>
Date: Fri, 23 Jan 2026 14:36:37 -0500
From: Joel Fernandes <joelagnelf@...dia.com>
To: <paulmck@...nel.org>
Cc: <linux-kernel@...r.kernel.org>, Boqun Feng <boqun.feng@...il.com>,
<rcu@...r.kernel.org>, Frederic Weisbecker <frederic@...nel.org>,
Neeraj Upadhyay <neeraj.upadhyay@...nel.org>,
Josh Triplett <josh@...htriplett.org>,
Uladzislau Rezki <urezki@...il.com>,
Steven Rostedt <rostedt@...dmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
Lai Jiangshan <jiangshanlai@...il.com>,
Zqiang <qiang.zhang@...ux.dev>
Subject: Re: [PATCH -next v3 2/3] rcu/nocb: Remove dead callback overload
handling
On 1/23/2026 11:49 AM, Paul E. McKenney wrote:
> We could have one CPU flooding and the rest idle, and many other
> combinations. And, if I recall correctly, polling can burn extra CPU
> and cause extra wakeups even when the system is fully idle. Or has
> that changed?
In my experience working on lazy RCU, if you have such a kind of overload on
any CPU, then you're usually not saving any power anyway. The system has to
be really quiet and idle with a low stream of callbacks for you to save
power. Further, when the callback length increases too much, we don't turn
on lazy RCU anyway because the idea is that we are overloaded and the
system is busy - so we already have such assumptions baked in. I think a
similar argument could apply here for dynamically enabling polling mode only
when overloaded.
I was coming more from the point of view of improving grace period performance
when we do have an overload, potentially resolving the overloaded situation
faster than usual. We would dynamically trigger polling based on such
circumstances.
That said, I confess I don't have extensive experience with polling mode beyond
testing. I believe we should add more rcutorture test cases for this. I'm
considering adding a new config that enables polling for NOCB - this testing is
what revealed the potential for grace period performance improvement with NOCB
to me.
--
Joel Fernandes
Powered by blists - more mailing lists