linux-kernel - Re: [PATCH] landlock: fix struct layer_access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260123.0fc66f6d76a2@gnoack.org>
Date: Fri, 23 Jan 2026 23:29:00 +0100
From: Günther Noack <gnoack3000@...il.com>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: linux-kernel@...r.kernel.org,
	Mickaël Salaün <mic@...ikod.net>,
	linux-security-module@...r.kernel.org,
	Paul Moore <paul@...l-moore.com>, James Morris <jmorris@...ei.org>,
	"Serge E. Hallyn" <serge@...lyn.com>
Subject: Re: [PATCH] landlock: fix struct layer_access_masks kernel-doc

On Thu, Jan 22, 2026 at 06:51:19PM -0800, Randy Dunlap wrote:
> Use the correct struct name and describe the struct member in
> kernel-doc notation to prevent kernel-doc warnings.
> 
> WARNING: ../security/landlock/ruleset.h:313 expecting prototype for
>   struct layer_accesses. Prototype was for struct layer_access_masks instead
> 
> Fixes: 1ebf8e8d3245 ("landlock: Transpose the layer masks data structure")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> ---
> Something like this is needed. Feel free to massage/correct it some.

The code that ended up in linux-next is an ongoing patch set and was
not the final version yet, so I'll take the liberty to include a
rewritten and fixed documentation in that place in the next patch set
version (I'll CC you).
https://lore.kernel.org/all/20251230103917.10549-3-gnoack3000@gmail.com/

Thank you for spotting this so quickly! We had actually overlooked it
in the code review so far.

–Günther