linux-kernel - Re: [PATCH kernel 1/2] crypto/ccp: Use PCI bridge defaults for IDE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6973fac6a8fea_309510044@dwillia2-mobl4.notmuch>
Date: Fri, 23 Jan 2026 14:48:38 -0800
From: <dan.j.williams@...el.com>
To: Alexey Kardashevskiy <aik@....com>, <linux-crypto@...r.kernel.org>
CC: <linux-kernel@...r.kernel.org>, Ashish Kalra <ashish.kalra@....com>, "Tom
 Lendacky" <thomas.lendacky@....com>, John Allen <john.allen@....com>,
	"Herbert Xu" <herbert@...dor.apana.org.au>, "David S. Miller"
	<davem@...emloft.net>, Dan Williams <dan.j.williams@...el.com>, Alexey
 Kardashevskiy <aik@....com>, <x86@...nel.org>, <linux-coco@...ts.linux.dev>,
	"Pratik R . Sampat" <prsampat@....com>
Subject: Re: [PATCH kernel 1/2] crypto/ccp: Use PCI bridge defaults for IDE

Alexey Kardashevskiy wrote:
> The current number of streams in AMD TSM is 1 which is too little,
> the core uses 255. Also, even if the module parameter is increased,
> calling pci_ide_set_nr_streams() second time triggers WARN_ON.
> 
> Simplify the code by sticking to the PCI core defaults.
> 
> Fixes: 4be423572da1 ("crypto/ccp: Implement SEV-TIO PCIe IDE (phase1)")
> Signed-off-by: Alexey Kardashevskiy <aik@....com>
> ---
>  drivers/crypto/ccp/sev-dev-tsm.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/drivers/crypto/ccp/sev-dev-tsm.c b/drivers/crypto/ccp/sev-dev-tsm.c
> index ea29cd5d0ff9..7407b77c2ef2 100644
> --- a/drivers/crypto/ccp/sev-dev-tsm.c
> +++ b/drivers/crypto/ccp/sev-dev-tsm.c
> @@ -19,12 +19,6 @@
>  
>  MODULE_IMPORT_NS("PCI_IDE");
>  
> -#define TIO_DEFAULT_NR_IDE_STREAMS	1
> -
> -static uint nr_ide_streams = TIO_DEFAULT_NR_IDE_STREAMS;
> -module_param_named(ide_nr, nr_ide_streams, uint, 0644);
> -MODULE_PARM_DESC(ide_nr, "Set the maximum number of IDE streams per PHB");
> -

Yes, happy to see any reduction in ABI surface, especially module
parameters.

Acked-by: Dan Williams <dan.j.williams@...el.com>