[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20260123061955.GB25722@lst.de>
Date: Fri, 23 Jan 2026 07:19:55 +0100
From: Christoph Hellwig <hch@....de>
To: Hongbo Li <lihongbo22@...wei.com>
Cc: Christoph Hellwig <hch@....de>, hsiangkao@...ux.alibaba.com,
chao@...nel.org, brauner@...nel.org, djwong@...nel.org,
amir73il@...il.com, linux-fsdevel@...r.kernel.org,
linux-erofs@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v15 5/9] erofs: introduce the page cache share feature
On Thu, Jan 22, 2026 at 10:48:27PM +0800, Hongbo Li wrote:
> Sorry I overlooked this point. Factoring this out is a good idea, but we
> cannot use IS_ENABLED here, because some aops is not visible when the
> relevant config macro is not enabled. So I choose to keep this format and
> only to factor this out.
Is it? If so just moving the extern outside the ifdef should be
easy enough, but from a quick grep I can't see any such case.
Powered by blists - more mailing lists