linux-kernel - Re: [PATCH v2] x86/sgx: use vm_flags_t for vm_prot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2c33338d030f086d490f6e8e8d02667ff37143ec.camel@intel.com>
Date: Fri, 23 Jan 2026 07:58:27 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "tianwentong2000@...il.com" <tianwentong2000@...il.com>
CC: "linux-sgx@...r.kernel.org" <linux-sgx@...r.kernel.org>, "bp@...en8.de"
	<bp@...en8.de>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"jarkko@...nel.org" <jarkko@...nel.org>, "dave.hansen@...ux.intel.com"
	<dave.hansen@...ux.intel.com>, "mingo@...hat.com" <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>, "tglx@...nel.org" <tglx@...nel.org>
Subject: Re: [PATCH v2] x86/sgx: use vm_flags_t for vm_prot_bits


> > With vm_flags_t I think "theoretically" it could stop being integer type
> > someday. But I guess the advantage is when someone does that that can
> > trigger build error here (so that we can be aware) which perhaps isn't a
> > bad thing?
> You're right, the build error would be a useful early warning if
> vm_flags_t ever becomes incompatible. 
> 

Agreed.  It's what type safety means IMHO.


> I'm fine either way, let me know
> if you'd prefer keeping
> unsigned long and I'll send a v3.

It's up to maintainer(s), but v2 makes sense to me, so:

Acked-by: Kai Huang <kai.huang@...el.com>