linux-kernel - Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <15e8aac4-6633-49b0-87fb-4b29f62afb2f@kernel.org>
Date: Fri, 23 Jan 2026 09:05:46 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pritam Manohar Sutar <pritam.sutar@...sung.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, alim.akhtar@...sung.com
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
 rosa.pila@...sung.com, dev.tailor@...sung.com, faraz.ata@...sung.com,
 muhammed.ali@...sung.com, selvarasu.g@...sung.com
Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB
 nodes

On 23/01/2026 08:59, Pritam Manohar Sutar wrote:
> Hi Krzysztof,
> 
> Thank you for your feedback. 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@...nel.org>
>> Sent: 22 January 2026 07:05 PM
>> To: Pritam Manohar Sutar <pritam.sutar@...sung.com>; robh@...nel.org;
>> krzk+dt@...nel.org; conor+dt@...nel.org; alim.akhtar@...sung.com
>> Cc: devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-
>> samsung-soc@...r.kernel.org; linux-kernel@...r.kernel.org;
>> rosa.pila@...sung.com; dev.tailor@...sung.com;
>> faraz.ata@...sung.com; muhammed.ali@...sung.com;
>> selvarasu.g@...sung.com
>> Subject: Re: [PATCH v2 3/3] arm64: dts: exynos: ExynosAutov920: Enable USB
>> nodes
>>
>> On 22/01/2026 14:07, Pritam Manohar Sutar wrote:
>>> Enable USB PHY and DWC3 USB controllers' nodes.
>>>
>>> Signed-off-by: Pritam Manohar Sutar <pritam.sutar@...sung.com>
>>> ---
>>>  .../boot/dts/exynos/exynosautov920-sadk.dts   | 21
>> +++++++++++++++++++
>>>  1 file changed, 21 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> index f90f7704597c..5896dd69334a 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> +++ b/arch/arm64/boot/dts/exynos/exynosautov920-sadk.dts
>>> @@ -160,15 +160,20 @@ &xtcxo {
>>>  &usbdrd31_ssphy {
>>>  	dvdd-supply = <&dummy_regulator>;
>>>  	vdd18-supply = <&dummy_regulator>;
>>> +	status = "okay";
>>
>> You just added the node in the previous patch, so why it cant be enavled
>> there?
>>
>>>  };
>>>
>>>  &usbdrd31_hsphy {
>>>  	dvdd-supply = <&dummy_regulator>;
>>>  	vdd18-supply = <&dummy_regulator>;
>>>  	vdd33-supply = <&dummy_regulator>;
>>> +	status = "okay";
>>>  };
>>>
>>>  &usbdrd31_dwc3 {
>>> +	dr_mode = "otg";
>>> +	usb-role-switch;
>>> +	role-switch-default-mode = "peripheral";
>>
>> Why did you add incomplete node in previous commit?
> 
> The commit was added to align with the existing convention of separating 
> node addition and enabling logic in USB configurations. This approach is 

There was never such convention for Qualcomm or Samsung. Do not make up
fake conventions.

> referenced from commits such as:

No, it is not.

> 
> https://lore.kernel.org/all/20250710-resends-july-exynos990-dt-v2-5-55033f73d1b0@mentallysanemainliners.org/
> https://lore.kernel.org/all/20240429-usb-dts-gs101-v2-2-7c1797c9db80@linaro.org/

Just look at these commits - they add complete node override to DTS. Not
half node now and half node later to the DTS file!

> 
> Please let me know if this commit to be merged in previous commit.

Just look at the commits there.

> 


Best regards,
Krzysztof