linux-kernel - Re: [RFC PATCH bpf-next v3 10/12] mm/bpf: Add BPF_F_ALLOW_OVERRIDE support for memcg_bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d2161f4252546f252dd0a84c461ba5dbb3b63e22d4826771edd8f1f30df050bc@mail.kernel.org>
Date: Fri, 23 Jan 2026 09:29:42 +0000 (UTC)
From: bot+bpf-ci@...nel.org
To: hui.zhu@...ux.dev,akpm@...ux-foundation.org,hannes@...xchg.org,mhocko@...nel.org,roman.gushchin@...ux.dev,shakeel.butt@...ux.dev,muchun.song@...ux.dev,ast@...nel.org,daniel@...earbox.net,andrii@...nel.org,martin.lau@...ux.dev,eddyz87@...il.com,song@...nel.org,yonghong.song@...ux.dev,john.fastabend@...il.com,kpsingh@...nel.org,sdf@...ichev.me,haoluo@...gle.com,jolsa@...nel.org,shuah@...nel.org,peterz@...radead.org,ojeda@...nel.org,nathan@...nel.org,kees@...nel.org,tj@...nel.org,jeffxu@...omium.org,mkoutny@...e.com,kernel@...rr.cc,brauner@...nel.org,rdunlap@...radead.org,brgerst@...il.com,masahiroy@...nel.org,davem@...emloft.net,kuba@...nel.org,hawk@...nel.org,inwardvessel@...il.com,willemb@...gle.com,kerneljasonxing@...il.com,paul.chaignon@...il.com,a.s.protopopov@...il.com,ameryhung@...il.com,chenridong@...weicloud.com,lance.yang@...ux.dev,jiayuan.chen@...ux.dev,linux-kernel@...r.kernel.org,linux-mm@...ck.org,cgroups@...r.kernel.org,bpf@...r.kernel.org,netdev@...r.kernel.org,linu
 x-kselftest@...r.kernel.org
Cc: zhuhui@...inos.cn,geliang@...nel.org,ast@...nel.org,andrii@...nel.org,daniel@...earbox.net,martin.lau@...nel.org,eddyz87@...il.com,yonghong.song@...ux.dev,clm@...a.com,ihor.solodrai@...ux.dev
Subject: Re: [RFC PATCH bpf-next v3 10/12] mm/bpf: Add BPF_F_ALLOW_OVERRIDE support for  memcg_bpf_ops

> diff --git a/mm/bpf_memcontrol.c b/mm/bpf_memcontrol.c
> index 415e3c59b6a6..0ded1fdd0de8 100644
> --- a/mm/bpf_memcontrol.c
> +++ b/mm/bpf_memcontrol.c

[ ... ]

> static int bpf_memcg_ops_reg(void *kdata, struct bpf_link *link)
> {
> 	struct bpf_struct_ops_link *ops_link
> 		= container_of(link, struct bpf_struct_ops_link, link);
> 	struct memcg_bpf_ops *ops = kdata;
> 	struct mem_cgroup *memcg, *iter = NULL;
> 	int err = 0;
>
> +	if (ops_link->flags & ~BPF_F_ALLOW_OVERRIDE) {
> +		pr_err("attach only support BPF_F_ALLOW_OVERRIDE\n");
> +		return -EOPNOTSUPP;
> +	}
> +
> 	memcg = mem_cgroup_get_from_ino(ops_link->cgroup_id);
> 	if (IS_ERR_OR_NULL(memcg))
> 		return PTR_ERR(memcg);
>
> 	cgroup_lock();
> +
> +	if (READ_ONCE(memcg->bpf_ops)) {
> +		/* Check if bpf_ops of the parent is BPF_F_ALLOW_OVERRIDE. */
> +		if (memcg->bpf_ops_flags & BPF_F_ALLOW_OVERRIDE) {
> +			iter = parent_mem_cgroup(memcg);
> +
> +			if (!iter)
> +				goto busy_out;
> +			if (READ_ONCE(iter->bpf_ops) !=
> +			    READ_ONCE(memcg->bpf_ops))
> +				goto busy_out;
> +		} else {
> +busy_out:
> +			err = -EBUSY;
> +			goto unlock_out;
> +		}
> +	}
> +
> 	while ((iter = mem_cgroup_iter(memcg, iter, NULL))) {
                                      ^^^^

When the override check passes (all conditions at lines 363-377 are met),
iter is set to parent_mem_cgroup(memcg) but is never reset to NULL before
this loop. Should iter be reset to NULL here?

The mem_cgroup_iter() function expects prev (iter) to be either NULL or a
previous result from iterating within memcg's descendants. When iter points
to memcg's parent, the iteration will not correctly traverse memcg's
subtree since parent is outside that subtree.

For comparison, bpf_memcg_ops_unreg() correctly resets iter to NULL before
its loop:

> +	iter = NULL;
> +	while ((iter = mem_cgroup_iter(memcg, iter, NULL))) {

> 		if (READ_ONCE(iter->bpf_ops)) {
> -			mem_cgroup_iter_break(memcg, iter);
> -			err = -EBUSY;
> -			break;
> +			/* cannot override existing bpf_ops of sub-cgroup. */
> +			continue;
> 		}
> 		WRITE_ONCE(iter->bpf_ops, ops);
> +		iter->bpf_ops_flags = ops_link->flags;
> 	}

[ ... ]


---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

CI run summary: https://github.com/kernel-patches/bpf/actions/runs/21280790825