linux-kernel - Re: [PATCH v2 1/1] PCI/IDE: Fix using wrong VF ID for RID range calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6972d0762f71e_1d3310065@dwillia2-mobl4.notmuch>
Date: Thu, 22 Jan 2026 17:35:50 -0800
From: <dan.j.williams@...el.com>
To: Li Ming <ming.li@...omail.com>, <helgaas@...nel.org>,
	<dan.j.williams@...el.com>
CC: <linux-pci@...r.kernel.org>, <linux-coco@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, Li Ming <ming.li@...omail.com>
Subject: Re: [PATCH v2 1/1] PCI/IDE: Fix using wrong VF ID for RID range
 calculation

I will change this subject to "PCI/IDE: Fix off by one error calculating VF RID range"

Li Ming wrote:
> When allocate a new IDE stream for a PCI device in SR-IOV case, the RID
> range of the new IDE stream should cover all VFs of the device. VF ID
> range of a PCI device is [0, num_VFs - 1], so should use (num_VFs - 1)
> as the last VF's ID.

This can be even more succinct / to the point:

---
The VF ID range of an SR-IOV device is [0, num_VFs - 1].
pci_ide_stream_alloc() mistakenly uses num_VFs to represent the last ID.
Fix that off by one error to stay in bounds of the range.
---

...but otherwise this looks good to me. Thanks!