| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20260123095346.1258556-5-sheetal@nvidia.com>
Date: Fri, 23 Jan 2026 15:23:46 +0530
From: "Sheetal ." <sheetal@...dia.com>
To: Mark Brown <broonie@...nel.org>
CC: Sander Vanheule <sander@...nheule.net>, Greg Kroah-Hartman
<gregkh@...uxfoundation.org>, "Rafael J . Wysocki" <rafael@...nel.org>,
Danilo Krummrich <dakr@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, "Thierry
Reding" <thierry.reding@...il.com>, Jonathan Hunter <jonathanh@...dia.com>,
Mohan kumar <mkumard@...dia.com>, <linux-kernel@...r.kernel.org>,
<linux-sound@...r.kernel.org>, <linux-tegra@...r.kernel.org>, Sheetal
<sheetal@...dia.com>
Subject: [RFC PATCH v3 4/4] regmap: add KUnit coverage for reg_default_cb callback
From: Sheetal <sheetal@...dia.com>
Add a flat-cache KUnit test that verifies reg_defaults are honored while
missing entries are populated via the reg_default_cb callback without
hardware reads. This exercises the new callback path added for
REGCACHE_FLAT defaults.
Test: ./tools/testing/kunit/kunit.py run regmap
Result:
======== reg_default_callback_populates_flat_cache ========
[PASSED] flat-default @0x0
[PASSED] flat-default fast I/O @0x0
[PASSED] flat-default @0x2001
==== [PASSED] reg_default_callback_populates_flat_cache ====
Signed-off-by: Sheetal <sheetal@...dia.com>
---
drivers/base/regmap/regmap-kunit.c | 91 ++++++++++++++++++++++++++++++
1 file changed, 91 insertions(+)
diff --git a/drivers/base/regmap/regmap-kunit.c b/drivers/base/regmap/regmap-kunit.c
index f6fc5ed016da..38c20a09670c 100644
--- a/drivers/base/regmap/regmap-kunit.c
+++ b/drivers/base/regmap/regmap-kunit.c
@@ -15,6 +15,8 @@ KUNIT_DEFINE_ACTION_WRAPPER(regmap_exit_action, regmap_exit, struct regmap *);
struct regmap_test_priv {
struct device *dev;
+ bool *reg_default_called;
+ unsigned int reg_default_max;
};
struct regmap_test_param {
@@ -118,6 +120,14 @@ static const struct regmap_test_param real_cache_types_only_list[] = {
KUNIT_ARRAY_PARAM(real_cache_types_only, real_cache_types_only_list, param_to_desc);
+static const struct regmap_test_param flat_cache_types_list[] = {
+ { .cache = REGCACHE_FLAT, .from_reg = 0 },
+ { .cache = REGCACHE_FLAT, .from_reg = 0, .fast_io = true },
+ { .cache = REGCACHE_FLAT, .from_reg = 0x2001 },
+};
+
+KUNIT_ARRAY_PARAM(flat_cache_types, flat_cache_types_list, param_to_desc);
+
static const struct regmap_test_param real_cache_types_list[] = {
{ .cache = REGCACHE_FLAT, .from_reg = 0 },
{ .cache = REGCACHE_FLAT, .from_reg = 0, .fast_io = true },
@@ -248,6 +258,37 @@ static bool reg_5_false(struct device *dev, unsigned int reg)
return reg != (param->from_reg + 5);
}
+static unsigned int reg_default_expected(unsigned int reg)
+{
+ return 0x5a5a0000 | (reg & 0xffff);
+}
+
+static int reg_default_test_cb(struct device *dev, unsigned int reg,
+ unsigned int *def)
+{
+ struct kunit *test = dev_get_drvdata(dev);
+ struct regmap_test_priv *priv = test->priv;
+
+ if (priv && priv->reg_default_called && reg <= priv->reg_default_max)
+ priv->reg_default_called[reg] = true;
+
+ *def = reg_default_expected(reg);
+ return 0;
+}
+
+static void expect_reg_default_value(struct kunit *test, struct regmap *map,
+ struct regmap_ram_data *data,
+ struct regmap_test_priv *priv,
+ unsigned int reg)
+{
+ unsigned int val;
+
+ KUNIT_EXPECT_TRUE(test, priv->reg_default_called[reg]);
+ KUNIT_EXPECT_EQ(test, 0, regmap_read(map, reg, &val));
+ KUNIT_EXPECT_EQ(test, reg_default_expected(reg), val);
+ KUNIT_EXPECT_FALSE(test, data->read[reg]);
+}
+
static void basic_read_write(struct kunit *test)
{
struct regmap *map;
@@ -628,6 +669,54 @@ static void reg_defaults(struct kunit *test)
KUNIT_EXPECT_EQ(test, config.cache_type == REGCACHE_NONE, data->read[i]);
}
+static void reg_default_callback_populates_flat_cache(struct kunit *test)
+{
+ const struct regmap_test_param *param = test->param_value;
+ struct regmap_test_priv *priv = test->priv;
+ struct regmap *map;
+ struct regmap_config config;
+ struct regmap_ram_data *data;
+ unsigned int reg, val;
+ unsigned int defaults_end;
+
+ config = test_regmap_config;
+ config.num_reg_defaults = 3;
+ config.max_register = param->from_reg + BLOCK_TEST_SIZE - 1;
+ config.reg_default_cb = reg_default_test_cb;
+
+ priv->reg_default_max = config.max_register;
+ priv->reg_default_called = kunit_kcalloc(test, config.max_register + 1,
+ sizeof(*priv->reg_default_called),
+ GFP_KERNEL);
+ KUNIT_ASSERT_NOT_NULL(test, priv->reg_default_called);
+
+ map = gen_regmap(test, &config, &data);
+ KUNIT_ASSERT_FALSE(test, IS_ERR(map));
+ if (IS_ERR(map))
+ return;
+
+ for (reg = 0; reg <= config.max_register; reg++)
+ data->read[reg] = false;
+
+ defaults_end = param->from_reg + config.num_reg_defaults - 1;
+
+ for (reg = param->from_reg; reg <= defaults_end; reg++) {
+ KUNIT_EXPECT_FALSE(test, priv->reg_default_called[reg]);
+ KUNIT_EXPECT_EQ(test, 0, regmap_read(map, reg, &val));
+ KUNIT_EXPECT_EQ(test, data->vals[reg], val);
+ KUNIT_EXPECT_FALSE(test, data->read[reg]);
+ }
+
+ if (param->from_reg > 0)
+ expect_reg_default_value(test, map, data, priv, 0);
+
+ if (defaults_end + 1 <= config.max_register)
+ expect_reg_default_value(test, map, data, priv, defaults_end + 1);
+
+ if (config.max_register > defaults_end + 1)
+ expect_reg_default_value(test, map, data, priv, config.max_register);
+}
+
static void reg_defaults_read_dev(struct kunit *test)
{
struct regmap *map;
@@ -2058,6 +2147,8 @@ static struct kunit_case regmap_test_cases[] = {
KUNIT_CASE_PARAM(write_readonly, regcache_types_gen_params),
KUNIT_CASE_PARAM(read_writeonly, regcache_types_gen_params),
KUNIT_CASE_PARAM(reg_defaults, regcache_types_gen_params),
+ KUNIT_CASE_PARAM(reg_default_callback_populates_flat_cache,
+ flat_cache_types_gen_params),
KUNIT_CASE_PARAM(reg_defaults_read_dev, regcache_types_gen_params),
KUNIT_CASE_PARAM(register_patch, regcache_types_gen_params),
KUNIT_CASE_PARAM(stride, regcache_types_gen_params),
--
2.34.1
Powered by blists - more mailing lists