| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20260123-dev-b4-aaeon-mcu-driver-v2-3-9f4c00bfb5cb@bootlin.com>
Date: Fri, 23 Jan 2026 10:54:32 +0100
From: "Thomas Perrot (Schneider Electric)" <thomas.perrot@...tlin.com>
To: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Linus Walleij <linusw@...nel.org>,
Bartosz Golaszewski <brgl@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>,
Jérémie Dautheribes <jeremie.dautheribes@...tlin.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Guenter Roeck <linux@...ck-us.net>, Lee Jones <lee@...nel.org>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-gpio@...r.kernel.org, imx@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, linux-watchdog@...r.kernel.org,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
"Thomas Perrot (Schneider Electric)" <thomas.perrot@...tlin.com>
Subject: [PATCH v2 3/5] mfd: aaeon: Add SRG-IMX8PL MCU driver
Add Multi-Function Device (MFD) driver for the Aaeon SRG-IMX8PL
embedded controller. This driver provides the core I2C communication
interface and registers child devices (GPIO and watchdog controllers).
The MCU firmware version is queried during probe and logged for
diagnostic purposes. All I2C transactions are serialized using a mutex
to ensure proper communication with the microcontroller.
Co-developed-by: Jérémie Dautheribes (Schneider Electric) <jeremie.dautheribes@...tlin.com>
Signed-off-by: Jérémie Dautheribes (Schneider Electric) <jeremie.dautheribes@...tlin.com>
Signed-off-by: Thomas Perrot (Schneider Electric) <thomas.perrot@...tlin.com>
---
MAINTAINERS | 2 +
drivers/mfd/Kconfig | 9 +++
drivers/mfd/Makefile | 2 +
drivers/mfd/aaeon-mcu.c | 129 ++++++++++++++++++++++++++++++++++++++++++
include/linux/mfd/aaeon-mcu.h | 31 ++++++++++
5 files changed, 173 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 10f7d5b183795376b3fcdedc9c3835eecb9d0a3b..175c1e1b28b8151580ed340207d4a6fd59aa8853 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -191,6 +191,8 @@ M: Thomas Perrot <thomas.perrot@...tlin.com>
R: Jérémie Dautheribes <jeremie.dautheribes@...tlin.com>
S: Maintained
F: Documentation/devicetree/bindings/mfd/aaeon,srg-imx8pl-mcu.yaml
+F: drivers/mfd/aaeon-mcu.c
+F: include/linux/mfd/aaeon-mcu.h
AAEON UPBOARD FPGA MFD DRIVER
M: Thomas Richard <thomas.richard@...tlin.com>
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index aace5766b38aa5e46e32a8a7b42eea238159fbcf..befcc36c12931b273e8e45fe968e9556514fb959 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1574,6 +1574,15 @@ config AB8500_CORE
the irq_chip parts for handling the Mixed Signal chip events.
This chip embeds various other multimedia functionalities as well.
+config MFD_AAEON_MCU
+ tristate "Aaeon SRG-IMX8PL MCU Driver"
+ depends on I2C
+ help
+ Select this option to enable support for the Aaeon SRG-IMX8PL
+ onboard microcontroller (MCU). This driver provides the core
+ functionality to communicate with the MCU over I2C. The MCU
+ provides GPIO and watchdog functionality.
+
config MFD_DB8500_PRCMU
bool "ST-Ericsson DB8500 Power Reset Control Management Unit"
depends on UX500_SOC_DB8500
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index e75e8045c28afae975ac61d282b3b85af5440119..0bc3a10c787c55730131224fc1053fe35657dd71 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -304,3 +304,5 @@ obj-$(CONFIG_MFD_RSMU_SPI) += rsmu_spi.o rsmu_core.o
obj-$(CONFIG_MFD_UPBOARD_FPGA) += upboard-fpga.o
obj-$(CONFIG_MFD_LOONGSON_SE) += loongson-se.o
+
+obj-$(CONFIG_MFD_AAEON_MCU) += aaeon-mcu.o
diff --git a/drivers/mfd/aaeon-mcu.c b/drivers/mfd/aaeon-mcu.c
new file mode 100644
index 0000000000000000000000000000000000000000..b496fb6618ca49296c574531b778fcbb653a48f5
--- /dev/null
+++ b/drivers/mfd/aaeon-mcu.c
@@ -0,0 +1,129 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Aaeon MCU driver
+ *
+ * Copyright (C) 2025 Bootlin
+ * Author: Jérémie Dautheribes <jeremie.dautheribes@...tlin.com>
+ * Author: Thomas Perrot <thomas.perrot@...tlin.com>
+ */
+
+#include <linux/err.h>
+#include <linux/i2c.h>
+#include <linux/mfd/aaeon-mcu.h>
+#include <linux/mfd/core.h>
+#include <linux/platform_device.h>
+
+#define AAEON_MCU_FW_VERSION 0x76
+
+static struct mfd_cell aaeon_mcu_devs[] = {
+ {
+ .name = "aaeon-mcu-wdt",
+ },
+ {
+ .name = "aaeon-mcu-gpio",
+ },
+};
+
+static int aaeon_mcu_read_version(struct device *dev, u8 index, u8 *version)
+{
+ u8 cmd[3] = { AAEON_MCU_FW_VERSION, index, 0x00 };
+
+ return aaeon_mcu_i2c_xfer(dev, cmd, sizeof(cmd), version, sizeof(*version));
+}
+
+static int aaeon_mcu_print_fw_version(struct i2c_client *client)
+{
+ struct device *dev = &client->dev;
+ u8 major, minor;
+ int ret;
+
+ ret = aaeon_mcu_read_version(dev, 0x00, &major);
+ if (ret)
+ return ret;
+
+ ret = aaeon_mcu_read_version(dev, 0x01, &minor);
+ if (ret)
+ return ret;
+
+ dev_info(dev, "firmware version: v%d.%d\n", major, minor);
+
+ return 0;
+}
+
+int aaeon_mcu_i2c_xfer(struct device *dev,
+ const u8 *cmd, int cmd_len,
+ u8 *rsp, int rsp_len)
+{
+ struct i2c_client *client = to_i2c_client(dev);
+ struct aaeon_mcu_dev *mcu = i2c_get_clientdata(client);
+ int ret;
+
+ mutex_lock(&mcu->i2c_lock);
+
+ ret = i2c_master_send(client, cmd, cmd_len);
+ if (ret < 0)
+ goto unlock;
+
+ ret = i2c_master_recv(client, rsp, rsp_len);
+ if (ret < 0)
+ goto unlock;
+
+ if (ret != rsp_len) {
+ dev_err(dev,
+ "i2c recv count error (expected: %d, actual: %d)\n",
+ rsp_len, ret);
+ ret = -EIO;
+ goto unlock;
+ }
+
+ ret = 0;
+
+unlock:
+ mutex_unlock(&mcu->i2c_lock);
+ return ret;
+}
+EXPORT_SYMBOL_GPL(aaeon_mcu_i2c_xfer);
+
+static int aaeon_mcu_probe(struct i2c_client *client)
+{
+ struct aaeon_mcu_dev *mcu;
+ int ret;
+
+ mcu = devm_kzalloc(&client->dev, sizeof(*mcu), GFP_KERNEL);
+ if (!mcu)
+ return -ENOMEM;
+
+ i2c_set_clientdata(client, mcu);
+ mcu->dev = &client->dev;
+ mutex_init(&mcu->i2c_lock);
+
+ ret = aaeon_mcu_print_fw_version(client);
+ if (ret) {
+ dev_err(&client->dev, "unable to read firmware version\n");
+ return ret;
+ }
+
+ return devm_mfd_add_devices(mcu->dev, PLATFORM_DEVID_NONE, aaeon_mcu_devs,
+ ARRAY_SIZE(aaeon_mcu_devs), NULL, 0, NULL);
+}
+
+static const struct of_device_id aaeon_mcu_of_match[] = {
+ { .compatible = "aaeon,srg-imx8pl-mcu" },
+ {},
+};
+
+MODULE_DEVICE_TABLE(of, aaeon_mcu_of_match);
+
+static struct i2c_driver aaeon_mcu_driver = {
+ .driver = {
+ .name = "aaeon_mcu",
+ .of_match_table = aaeon_mcu_of_match,
+ },
+ .probe = aaeon_mcu_probe,
+};
+
+module_i2c_driver(aaeon_mcu_driver);
+
+MODULE_DESCRIPTION("Aaeon MCU Driver");
+MODULE_AUTHOR("Jérémie Dautheribes <jeremie.dautheribes@...tlin.com>");
+MODULE_LICENSE("GPL");
diff --git a/include/linux/mfd/aaeon-mcu.h b/include/linux/mfd/aaeon-mcu.h
new file mode 100644
index 0000000000000000000000000000000000000000..c9dc7a9adbc86c489f03a550e7776d3b1da4e7b2
--- /dev/null
+++ b/include/linux/mfd/aaeon-mcu.h
@@ -0,0 +1,31 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Aaeon MCU driver definitions
+ *
+ * Copyright (C) 2025 Bootlin
+ * Author: Jérémie Dautheribes <jeremie.dautheribes@...tlin.com>
+ * Author: Thomas Perrot <thomas.perrot@...tlin.com>
+ */
+
+#ifndef __LINUX_MFD_AAEON_MCU_H
+#define __LINUX_MFD_AAEON_MCU_H
+
+#include <linux/mutex.h>
+#include <linux/types.h>
+
+/**
+ * struct aaeon_mcu_dev - Internal representation of the Aaeon MCU
+ * @dev: Pointer to kernel device structure
+ * @i2c_lock: Mutex to serialize I2C bus access
+ */
+
+struct aaeon_mcu_dev {
+ struct device *dev;
+ struct mutex i2c_lock;
+};
+
+int aaeon_mcu_i2c_xfer(struct device *dev,
+ const u8 *cmd, int cmd_len,
+ u8 *rsp, int rsp_len);
+
+#endif /* __LINUX_MFD_AAEON_MCU_H */
--
2.52.0
Powered by blists - more mailing lists