linux-kernel - Re: [PATCH v2 2/2] samples: rust: fwctl: add sample code for fwctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260123122324.28fe6d38.zhiw@nvidia.com>
Date: Fri, 23 Jan 2026 12:23:24 +0200
From: Zhi Wang <zhiw@...dia.com>
To: John Hubbard <jhubbard@...dia.com>
CC: Danilo Krummrich <dakr@...nel.org>, Jason Gunthorpe <jgg@...dia.com>,
	<rust-for-linux@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <aliceryhl@...gle.com>,
	<bhelgaas@...gle.com>, <kwilczynski@...nel.org>, <ojeda@...nel.org>,
	<alex.gaynor@...il.com>, <boqun.feng@...il.com>, <gary@...yguo.net>,
	<bjorn3_gh@...tonmail.com>, <lossin@...nel.org>, <a.hindborg@...nel.org>,
	<tmgross@...ch.edu>, <markus.probst@...teo.de>, <helgaas@...nel.org>,
	<cjia@...dia.com>, <smitra@...dia.com>, <ankita@...dia.com>,
	<aniketa@...dia.com>, <kwankhede@...dia.com>, <targupta@...dia.com>,
	<acourbot@...dia.com>, <joelagnelf@...dia.com>, <zhiwang@...nel.org>,
	<daniel.almeida@...labora.com>
Subject: Re: [PATCH v2 2/2] samples: rust: fwctl: add sample code for fwctl

On Thu, 22 Jan 2026 13:16:29 -0800
John Hubbard <jhubbard@...dia.com> wrote:

> On 1/22/26 1:06 PM, Danilo Krummrich wrote:
> > On Thu Jan 22, 2026 at 9:58 PM CET, Jason Gunthorpe wrote:
> >> On Thu, Jan 22, 2026 at 10:42:31PM +0200, Zhi Wang wrote:
> >>> This patch adds a sample Rust driver demonstrating the usage of the
> >>> fwctl Rust abstractions. Add sample code for creating a FwCtl
> >>> device, getting device info and issuing an RPC.
> >>>
> >>> Cc: Danilo Krummrich <dakr@...nel.org>
> >>> Cc: Jason Gunthorpe <jgg@...dia.com>
> >>> Signed-off-by: Zhi Wang <zhiw@...dia.com>
> >>> ---
> >>>  samples/rust/Kconfig              |  11 +++
> >>>  samples/rust/Makefile             |   1 +
> >>>  samples/rust/rust_driver_fwctl.rs | 136
> >>> ++++++++++++++++++++++++++++++ 3 files changed, 148 insertions(+)
> >>>  create mode 100644 samples/rust/rust_driver_fwctl.rs
> >>
> >> Is this normal for Rust? Can we delete it when a real driver is
> >> merged?
> >>
> >> I'm not so keen on sample drivers, I've spent far too much time lately
> >> touching sample drivers that nobody ever uses :(
> > 
> > I think it is pretty useful for review purposes (at least as long as
> > the first real user is not yet ready) to see how it turns out from a
> > user perspective.
> > 
> > It may also be pretty useful for people starting out with Rust in the
> > kernel, as the samples have a very limited scope compared to real
> > drivers.
> > 
> > But there is no policy or anything, i.e. no need to keep it. There's
> > also no need to even land it if you prefer not to do so.
> 
> Zhi, the real code that uses this for vGPU is going to be posted
> soon-ish, right? So we could use this patch as a review assist, like
> Danilo mentions, but not merge it, because the real code will suffice to
> exercise the new fwctl functionality.
> 

I am OK with any solutions. My motivation of updating this one is because
of many changes and improvements in this re-spin comparing to the RFC. As
Jason/Danilo gave quite some feedback on RFC (Thanks for the review
efforts!), I would like to start the review before the vGPU patches.

Z.

> thanks,