[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <43923bf9-6202-4147-8eac-5bd7bb653fd4@gmail.com>
Date: Fri, 23 Jan 2026 02:47:18 -0800
From: Bo Gan <ganboing@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Andrew Lunn <andrew@...n.ch>,
李志 <lizhi2@...incomputing.com>
Cc: devicetree@...r.kernel.org, andrew+netdev@...n.ch, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, netdev@...r.kernel.org, pabeni@...hat.com,
mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
rmk+kernel@...linux.org.uk, linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
ningyu@...incomputing.com, linmin@...incomputing.com,
pinkesh.vaghela@...fochips.com, weishangjuan@...incomputing.com
Subject: Re: [PATCH v1 1/2] dt-bindings: ethernet: eswin: add clock sampling
control
Hi Krzysztof,
On 1/23/26 02:07, Krzysztof Kozlowski wrote:
> On 23/01/2026 08:39, Bo Gan wrote:
>>> I assume the address of the interface is fixed. So you can just key
>>> off that to distinguish the two instances.
>>>
>>> Since this is an internal property, not a board property, it is not
>>> clear it actually belongs on DT.
>>>
>>> Andrew
>>
>> IMO, they should be in DT to provide maximum flexibility. The SoC .dtsi
>
> This is not the purpose of DT. Please rather use arguments in terms of
> DT rules (see docs, presentations).
>
Any examples? links? Thank you for your patience.
I'd say if the board .dts never overrides the eswin,rx-clk-invert, (E.g.,
the SoC .dtsi has rx-clk-invert, later the board /delete-property/'s it)
then yes, it can be treated as something inherent to the mac, and then
"use arguments in terms of DT rules". I was thinking about use cases like:
https://lore.kernel.org/all/20230714104521.18751-3-samin.guo@starfivetech.com/
> We really do not care about maximum flexibility.
>
> Best regards,
> Krzysztof
Bo
Powered by blists - more mailing lists