linux-kernel - Re: [PATCH 11/11] soc: qcom: ice: Add explicit power-domain and clock voting calls for ICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <54bf72b6-6397-4655-9c30-680b1374400b@kernel.org>
Date: Fri, 23 Jan 2026 11:57:27 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Harshal Dev <harshal.dev@....qualcomm.com>,
 Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>,
 Abel Vesa <abel.vesa@....qualcomm.com>, cros-qcom-dts-watchers@...omium.org
Cc: Brian Masney <bmasney@...hat.com>,
 Neeraj Soni <neeraj.soni@....qualcomm.com>,
 Gaurav Kashyap <gaurav.kashyap@....qualcomm.com>,
 linux-arm-msm@...r.kernel.org, linux-crypto@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/11] soc: qcom: ice: Add explicit power-domain and clock
 voting calls for ICE

On 23/01/2026 09:58, Krzysztof Kozlowski wrote:
>>  
>>  	return 0;
>> @@ -584,6 +597,10 @@ static struct qcom_ice *qcom_ice_create(struct device *dev,
>>  	if (IS_ERR(engine->core_clk))
>>  		return ERR_CAST(engine->core_clk);
>>  
>> +	engine->iface_clk = devm_clk_get_enabled(dev, "iface_clk");
>> +	if (IS_ERR(engine->iface_clk))
>> +		return ERR_CAST(engine->iface_clk);
> 
> And here actual breakage of ALL in-tree and out-of-tree DTS.
> 
> NAK.
> 
> Please read internal guideline.

Internal docs are pretty scattered and messy so I failed to find this
there, which is surprising because this was frequent feedback. Therefore
please update Kernel Upstreaming internal page with following:

With few exceptions, it is not allowed to break the ABI, by making
bindings or driver changes, where the existing or out of tree DTS would
fail to boot. Updating in-tree DTS does not matter here, because DTS
goes via different branch, thus driver branch would be always broken.
This is explicitly documented in DT rules and explained also in
maintainer-soc profile.

You need to either provide strong justification for ABI break or make
the changes backwards compatible.

Best regards,
Krzysztof