linux-kernel - Re: [PATCH V3 5/5] mm/khugepaged: make khugepaged_collapse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260123190213.7f90fcbc6706d9ad57d2c974@linux-foundation.org>
Date: Fri, 23 Jan 2026 19:02:13 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Garg, Shivank" <shivankg@....com>, Dev Jain <dev.jain@....com>, David
 Hildenbrand <david@...nel.org>, Lorenzo Stoakes
 <lorenzo.stoakes@...cle.com>, Zi Yan <ziy@...dia.com>, Baolin Wang
 <baolin.wang@...ux.alibaba.com>, "Liam R . Howlett"
 <Liam.Howlett@...cle.com>, Nico Pache <npache@...hat.com>, Ryan Roberts
 <ryan.roberts@....com>, Barry Song <baohua@...nel.org>, Lance Yang
 <lance.yang@...ux.dev>, linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 Wei Yang <richard.weiyang@...il.com>, Anshuman Khandual
 <anshuman.khandual@....com>
Subject: Re: [PATCH V3 5/5] mm/khugepaged: make khugepaged_collapse_control
 static

On Fri, 23 Jan 2026 17:21:42 -0800 Andrew Morton <akpm@...ux-foundation.org> wrote:

> 
> lol, OK, I droppped $Subject and did this:
> 
> --- a/mm/khugepaged.c~mm-khugepaged-make-khugepaged_collapse_control-a-local
> +++ a/mm/khugepaged.c
> @@ -827,10 +827,6 @@ static void khugepaged_alloc_sleep(void)
>  	remove_wait_queue(&khugepaged_wait, &wait);
>  }
>  
> -struct collapse_control khugepaged_collapse_control = {
> -	.is_khugepaged = true,
> -};
> -
>  static bool hpage_collapse_scan_abort(int nid, struct collapse_control *cc)
>  {
>  	int i;
> @@ -2618,13 +2614,16 @@ static void khugepaged_wait_work(void)
>  
>  static int khugepaged(void *none)
>  {
> +	struct collapse_control cc = {
> +		.is_khugepaged = true,
> +	};

nope, that thing's really big!

mm/khugepaged.c: In function 'khugepaged':
mm/khugepaged.c:2637:1: error: the frame size of 4696 bytes is larger than 2048 

We could kzalloc() it but I think I'll just restore the make-it-static
patch.  Someone please add to the todo list?