linux-kernel - Re: [PATCH bpf-next v12 11/13] selftests/bpf: test bpf_get_func

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5962490.DvuYhMxLoT@7950hx>
Date: Sat, 24 Jan 2026 13:09:12 +0800
From: Menglong Dong <menglong.dong@...ux.dev>
To: Menglong Dong <menglong8.dong@...il.com>
Cc: andrii@...nel.org, ast@...nel.org, daniel@...earbox.net,
 martin.lau@...ux.dev, eddyz87@...il.com, song@...nel.org,
 yonghong.song@...ux.dev, john.fastabend@...il.com, kpsingh@...nel.org,
 sdf@...ichev.me, haoluo@...gle.com, jolsa@...nel.org, davem@...emloft.net,
 dsahern@...nel.org, tglx@...utronix.de, mingo@...hat.com,
 jiang.biao@...ux.dev, bp@...en8.de, dave.hansen@...ux.intel.com,
 x86@...nel.org, hpa@...or.com, bpf@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject:
 Re: [PATCH bpf-next v12 11/13] selftests/bpf: test bpf_get_func_* for
 fsession

On 2026/1/24 11:31, Menglong Dong wrote:
> Test following bpf helper for fsession:
>   bpf_get_func_arg()
>   bpf_get_func_arg_cnt()
>   bpf_get_func_ret()
>   bpf_get_func_ip()
> 
> Signed-off-by: Menglong Dong <dongml2@...natelecom.cn>
> ---
>  .../bpf/prog_tests/get_func_args_test.c       |  1 +
>  .../bpf/prog_tests/get_func_ip_test.c         |  2 ++
>  .../selftests/bpf/progs/get_func_args_test.c  | 31 ++++++++++++++++++-
>  .../selftests/bpf/progs/get_func_ip_test.c    | 14 +++++++++
>  4 files changed, 47 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/get_func_args_test.c b/tools/testing/selftests/bpf/prog_tests/get_func_args_test.c
> index fadee95d3ae8..96b27de05524 100644
> --- a/tools/testing/selftests/bpf/prog_tests/get_func_args_test.c
> +++ b/tools/testing/selftests/bpf/prog_tests/get_func_args_test.c
> @@ -41,6 +41,7 @@ void test_get_func_args_test(void)
>  	ASSERT_EQ(skel->bss->test4_result, 1, "test4_result");
>  	ASSERT_EQ(skel->bss->test5_result, 1, "test5_result");
>  	ASSERT_EQ(skel->bss->test6_result, 1, "test6_result");
> +	ASSERT_EQ(skel->bss->test7_result, 1, "test7_result");
>  
>  cleanup:
>  	get_func_args_test__destroy(skel);
> diff --git a/tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c b/tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c
> index c40242dfa8fb..7772a0f288d3 100644
> --- a/tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c
> +++ b/tools/testing/selftests/bpf/prog_tests/get_func_ip_test.c
> @@ -46,6 +46,8 @@ static void test_function_entry(void)
>  	ASSERT_EQ(skel->bss->test5_result, 1, "test5_result");
>  	ASSERT_EQ(skel->bss->test7_result, 1, "test7_result");
>  	ASSERT_EQ(skel->bss->test8_result, 1, "test8_result");
> +	ASSERT_EQ(skel->bss->test9_entry_result, 1, "test9_entry_result");
> +	ASSERT_EQ(skel->bss->test9_exit_result, 1, "test9_exit_result");
>  
>  cleanup:
>  	get_func_ip_test__destroy(skel);
> diff --git a/tools/testing/selftests/bpf/progs/get_func_args_test.c b/tools/testing/selftests/bpf/progs/get_func_args_test.c
> index 5b7233afef05..8ecc5f339552 100644
> --- a/tools/testing/selftests/bpf/progs/get_func_args_test.c
> +++ b/tools/testing/selftests/bpf/progs/get_func_args_test.c
> @@ -1,5 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
> -#include <linux/bpf.h>
> +#include <vmlinux.h>
>  #include <bpf/bpf_helpers.h>
>  #include <bpf/bpf_tracing.h>
>  #include <errno.h>
> @@ -165,3 +165,32 @@ int BPF_PROG(tp_test2)
>  
>  	return 0;
>  }
> +
> +__u64 test7_result = 0;
> +SEC("fsession/bpf_fentry_test1")
> +int BPF_PROG(test7)
> +{
> +	__u64 cnt = bpf_get_func_arg_cnt(ctx);
> +	__u64 a = 0, z = 0, ret = 0;
> +	__s64 err;
> +
> +	test7_result = cnt == 1;
> +
> +	/* valid arguments */
> +	err = bpf_get_func_arg(ctx, 0, &a);
> +	test7_result &= err == 0 && ((int) a == 1);
> +
> +	/* not valid argument */
> +	err = bpf_get_func_arg(ctx, 1, &z);
> +	test7_result &= err == -EINVAL;
> +
> +	if (bpf_session_is_return(ctx)) {
> +		err = bpf_get_func_ret(ctx, &ret);
> +		test7_result &= err == 0 && ret == 2;
> +	} else {
> +		err = bpf_get_func_ret(ctx, &ret);
> +		test7_result &= err == 0 && ret == 0;
> +	}
> +
> +	return 0;
> +}

CI failed, as this testcase can't run on !CONFIG_X86_64, and
"#ifdef __TARGET_ARCH_x86" should be used here.

Will send a V13 later :)

> diff --git a/tools/testing/selftests/bpf/progs/get_func_ip_test.c b/tools/testing/selftests/bpf/progs/get_func_ip_test.c
> index 2011cacdeb18..bd7598a037cd 100644
> --- a/tools/testing/selftests/bpf/progs/get_func_ip_test.c
> +++ b/tools/testing/selftests/bpf/progs/get_func_ip_test.c
> @@ -103,3 +103,17 @@ int BPF_URETPROBE(test8, int ret)
>  	test8_result = (const void *) addr == (const void *) uprobe_trigger;
>  	return 0;
>  }
> +
> +__u64 test9_exit_result = 0;
> +__u64 test9_entry_result = 0;
> +SEC("fsession/bpf_fentry_test1")
> +int BPF_PROG(test9, int a)
> +{
> +	__u64 addr = bpf_get_func_ip(ctx);
> +
> +	if (bpf_session_is_return(ctx))
> +		test9_exit_result = (const void *) addr == &bpf_fentry_test1;
> +	else
> +		test9_entry_result = (const void *) addr == &bpf_fentry_test1;
> +	return 0;
> +}
>