linux-kernel - Re: [PATCH] ext4: remove unused i_fc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f20b78a1-82c2-4864-a996-585c703573e7@gmail.com>
Date: Sat, 24 Jan 2026 16:18:47 +0800
From: Zhang Yi <yizhang089@...il.com>
To: Li Chen <me@...ux.beauty>, Theodore Ts'o <tytso@....edu>,
 Andreas Dilger <adilger.kernel@...ger.ca>, linux-ext4@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: remove unused i_fc_wait

On 1/20/2026 8:19 PM, Li Chen wrote:
> i_fc_wait is only initialized in ext4_fc_init_inode() and never used for
> waiting or wakeups. Drop it.
> 
> Signed-off-by: Li Chen <me@...ux.beauty>

Thank you for the cleanup, it looks good to me.

Reviewed-by: Zhang Yi <yi.zhang@...wei.com>

> ---
>   fs/ext4/ext4.h        | 4 ----
>   fs/ext4/fast_commit.c | 2 +-
>   2 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 56112f201cac..dc3a5a926eff 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -28,7 +28,6 @@
>   #include <linux/seqlock.h>
>   #include <linux/mutex.h>
>   #include <linux/timer.h>
> -#include <linux/wait.h>
>   #include <linux/sched/signal.h>
>   #include <linux/blockgroup_lock.h>
>   #include <linux/percpu_counter.h>
> @@ -1091,9 +1090,6 @@ struct ext4_inode_info {
>   
>   	spinlock_t i_raw_lock;	/* protects updates to the raw inode */
>   
> -	/* Fast commit wait queue for this inode */
> -	wait_queue_head_t i_fc_wait;
> -
>   	/*
>   	 * Protect concurrent accesses on i_fc_lblk_start, i_fc_lblk_len
>   	 * and inode's EXT4_FC_STATE_COMMITTING state bit.
> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> index fa66b08de999..86789989b3f4 100644
> --- a/fs/ext4/fast_commit.c
> +++ b/fs/ext4/fast_commit.c
> @@ -13,6 +13,7 @@
>   #include "mballoc.h"
>   
>   #include <linux/lockdep.h>
> +#include <linux/wait_bit.h>
>   /*
>    * Ext4 Fast Commits
>    * -----------------
> @@ -215,7 +216,6 @@ void ext4_fc_init_inode(struct inode *inode)
>   	ext4_clear_inode_state(inode, EXT4_STATE_FC_COMMITTING);
>   	INIT_LIST_HEAD(&ei->i_fc_list);
>   	INIT_LIST_HEAD(&ei->i_fc_dilist);
> -	init_waitqueue_head(&ei->i_fc_wait);
>   }
>   
>   static bool ext4_fc_disabled(struct super_block *sb)