linux-kernel - Re: [PATCH v2] vmcoreinfo: make hwerr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260123164950.6988b5fe7e11d5986e399752@linux-foundation.org>
Date: Fri, 23 Jan 2026 16:49:50 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Breno Leitao <leitao@...ian.org>
Cc: Baoquan He <bhe@...hat.com>, vgoyal@...hat.com, dyoung@...hat.com,
 xueshuai@...ux.alibaba.com, tony.luck@...el.com,
 linux-kernel@...r.kernel.org, osandov@...ndov.com, kernel-team@...a.com
Subject: Re: [PATCH v2] vmcoreinfo: make hwerr_data visible for debugging

On Fri, 23 Jan 2026 01:24:17 -0800 Breno Leitao <leitao@...ian.org> wrote:

> Hello Baoquan,
> 
> On Fri, Jan 23, 2026 at 08:19:40AM +0800, Baoquan He wrote:
> > On 01/22/26 at 02:39am, Breno Leitao wrote:
> > > If the kernel is compiled with LTO, hwerr_data symbol might be lost, and
> > > vmcoreinfo doesn't have it dumped. This is currently seen in some
> > > production kernels with LTO enabled.
> > > 
> > > Remove the static qualifier from hwerr_data so that the information is
> > > still preserved when the kernel is built with LTO. Making hwerr_data
> > > a global symbol ensures its debug info survives the LTO link process and
> > > appears in kallsyms. Also document it, so, it doesn't get removed in the
> > > future as suggested by akpm.
> > > 
> > > Signed-off-by: Breno Leitao <leitao@...ian.org>
> > > ---
> > > Changes in v2:
> > > - Add a comment to explain why the array is global (akpm)
> > > - Link to v1: https://patch.msgid.link/20260121-fix_vmcoreinfo-v1-1-39e96fab670e@debian.org
> > > ---
> > >  kernel/vmcore_info.c | 6 +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > 
> > LGTM,
> > 
> > Acked-by: Baoquan He <bhe@...hat.com>
> > 
> > BTW, is it worth a 'Fixes' tag?
> 
> I am not sure, but, if we prefer to, this is the correct tag:
> 
> Fixes: 3fa805c37dd4d ("vmcoreinfo: track and log recoverable hardware errors")

3fa805c37dd4d was added in 6.19-rc1, so this patch is a fixup against
this rc series.  So yes, it should go into 6.19-rcX also.

I hadn't noticed the timing here so thanks both for pointing it out.