linux-kernel - Re: [PATCH] fs: reset read-only fsflags together with xflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260124182959.GB2762@quark>
Date: Sat, 24 Jan 2026 10:29:59 -0800
From: Eric Biggers <ebiggers@...nel.org>
To: Andrey Albershteyn <aalbersh@...nel.org>
Cc: brauner@...nel.org, jack@...e.cz, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: reset read-only fsflags together with xflags

On Wed, Jan 21, 2026 at 08:36:43PM +0100, Andrey Albershteyn wrote:
> While setting file attributes, the read-only flags are reset
> for ->xflags, but not for ->flags if flag is shared between both. This
> is fine for now as all read-only xflags don't overlap with flags.
> However, for any read-only shared flag this will create inconsistency
> between xflags and flags. The non-shared flag will be reset in
> vfs_fileattr_set() to the current value, but shared one is past further
> to ->fileattr_set.
> 
> Reported-by: Eric Biggers <ebiggers@...nel.org>
> Signed-off-by: Andrey Albershteyn <aalbersh@...nel.org>
> ---
> 
> The shared read-only flag is going to be added for fsverity. The one for ->flags
> already exists.
> 
> [1]: https://lore.kernel.org/linux-xfs/20260119165644.2945008-2-aalbersh@kernel.org/

Reviewed-by: Eric Biggers <ebiggers@...nel.org>

- Eric