linux-kernel - Re: [PATCH 28/31] gpu: nova-core: Hopper/Blackwell: add GSP lockdown release polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c5ca917-1ee5-4e2f-816a-25e77e842af8@nvidia.com>
Date: Fri, 23 Jan 2026 17:10:27 -0800
From: John Hubbard <jhubbard@...dia.com>
To: Gary Guo <gary@...yguo.net>, Danilo Krummrich <dakr@...nel.org>
Cc: Alexandre Courbot <acourbot@...dia.com>,
 Joel Fernandes <joelagnelf@...dia.com>, Timur Tabi <ttabi@...dia.com>,
 Alistair Popple <apopple@...dia.com>, Edwin Peer <epeer@...dia.com>,
 Zhi Wang <zhiw@...dia.com>, David Airlie <airlied@...il.com>,
 Simona Vetter <simona@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>, nouveau@...ts.freedesktop.org,
 rust-for-linux@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 28/31] gpu: nova-core: Hopper/Blackwell: add GSP lockdown
 release polling

On 1/21/26 8:20 AM, Gary Guo wrote:
> On Wed Dec 3, 2025 at 5:59 AM GMT, John Hubbard wrote:
...
>> +        read_poll_timeout(
>> +            || {
>> +                let released = Self::gsp_lockdown_released(
>> +                    dev,
>> +                    gsp_falcon,
>> +                    bar,
>> +                    fmc_boot_params_addr,
>> +                    &mut mbox0,
>> +                );
>> +
>> +                Ok((released, mbox0))
>> +            },
>> +            |(released, _)| *released,
>> +            Delta::ZERO,
>> +            Delta::from_millis(4000),
>> +        )
>> +        .inspect_err(|_| {
>> +            dev_err!(dev, "GSP lockdown release timeout\n");
>> +        })
> 
> Once you're done with the error, please just return early with `?` and not keep
> chaining.

Done.

thanks,
-- 
John Hubbard