linux-kernel - Re: [PATCH] drm/panel: boe-th101mb31ig002: Remove use of deprecated mipi_dsi_dcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD=FV=VhqTmEhVade6JPUz2_SBcw-J8NS2J7FNqR2j6qLFAJJw@mail.gmail.com>
Date: Sat, 24 Jan 2026 15:44:53 -0800
From: Doug Anderson <dianders@...omium.org>
To: Caio Ishikawa <caio.ishikawa@...ton.me>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Jessica Zhang <jesszhan0024@...il.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: boe-th101mb31ig002: Remove use of deprecated mipi_dsi_dcs_nop()

Hi,

On Sat, Jan 24, 2026 at 4:51 AM Caio Ishikawa <caio.ishikawa@...ton.me> wrote:
>
> Replace calls to deprecated mipi_dsi_dcs_nop() with
> mipi_dsi_dcs_nop_multi(). No intended functional changes.
>
> Signed-off-by: Caio Ishikawa <caio.ishikawa@...ton.me>
> ---
>  drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Hmmmm, I guess we missed this one call when we moved the rest of the
driver over to the _multi() functions.

While moving this one last call over to _multi() doesn't actually help
at all with code flow / readability (arguably, it makes it slightly
worse in this case), we did agree that it would be better to move
everyone over to the "multi" variants and deprecate the non-multi
ones. I guess, if nothing else, we'll now get an error printout if the
NOP fails to send, which is an improvement.

Reviewed-by: Douglas Anderson <dianders@...omium.org>

I'll try to apply in about a week if there are no other comments and
nobody beats me to it.

-Doug