linux-kernel - Re: [PATCH v2] RISC-V: KVM: Fix null pointer dereference in kvm_riscv_aia_imsic_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9a818ca6-04fc-434c-b8eb-8380d5bb2293@web.de>
Date: Sun, 25 Jan 2026 12:30:08 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: Jiakai Xu <xujiakai2025@...as.ac.cn>, kvm@...r.kernel.org,
 kvm-riscv@...ts.infradead.org, linux-riscv@...ts.infradead.org
Cc: Jiakai Xu <jiakaipeanut@...il.com>, LKML <linux-kernel@...r.kernel.org>,
 Albert Ou <aou@...s.berkeley.edu>, Alexandre Ghiti <alex@...ti.fr>,
 Anup Patel <anup@...infault.org>, Atish Patra <atish.patra@...ux.dev>,
 Palmer Dabbelt <palmer@...belt.com>, Paul Walmsley <pjw@...nel.org>
Subject: Re: [PATCH v2] RISC-V: KVM: Fix null pointer dereference in
 kvm_riscv_aia_imsic_has_attr

…
> The fix adds a check to return -ENODEV if imsic_state is NULL, which
> is consistent with other error handling in the function and prevents
> the null pointer dereference.

How do you think about to move the assignment for the local variable “isel”
behind this check by another update step?
https://elixir.bootlin.com/linux/v6.19-rc5/source/arch/riscv/kvm/aia_imsic.c#L982-L999

> v2: add Fixes tag and drop external link as suggested.

Please move a patch version description behind the marker line.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.19-rc6#n785

Would it be helpful to append parentheses to a function name also in the summary phrase?

Regards,
Markus