linux-kernel - Re: [PATCH] kho: fix doc for kho_restore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXYDov8RruYZszaQ@kernel.org>
Date: Sun, 25 Jan 2026 13:50:58 +0200
From: Mike Rapoport <rppt@...nel.org>
To: Tycho Andersen <tycho@...nel.org>
Cc: Alexander Graf <graf@...zon.com>,
	Pasha Tatashin <pasha.tatashin@...een.com>,
	Pratyush Yadav <pratyush@...nel.org>, kexec@...ts.infradead.org,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kho: fix doc for kho_restore_pages()

On Fri, Jan 23, 2026 at 12:05:06PM -0700, Tycho Andersen wrote:
> From: "Tycho Andersen (AMD)" <tycho@...nel.org>
> 
> This function returns NULL if kho_restore_page() returns NULL, which
> happens in a couple of corner cases. It never returns an error code.
> 
> Signed-off-by: Tycho Andersen (AMD) <tycho@...nel.org>

Reviewed-by: Mike Rapoport (Microsoft) <rppt@...nel.org>

> ---
>  kernel/liveupdate/kexec_handover.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c
> index d4482b6e3cae..4c38ea7987c8 100644
> --- a/kernel/liveupdate/kexec_handover.c
> +++ b/kernel/liveupdate/kexec_handover.c
> @@ -281,7 +281,7 @@ EXPORT_SYMBOL_GPL(kho_restore_folio);
>   * Restore a contiguous list of order 0 pages that was preserved with
>   * kho_preserve_pages().
>   *
> - * Return: 0 on success, error code on failure
> + * Return: the first page on success, NULL on failure.
>   */
>  struct page *kho_restore_pages(phys_addr_t phys, unsigned int nr_pages)
>  {
> 
> base-commit: c072629f05d7bca1148ab17690d7922a31423984
> -- 
> 2.52.0
> 

-- 
Sincerely yours,
Mike.