linux-kernel - Re: [PATCH 2/2] irqchip/apple-aic: Add support for "apple,t8122-aic3"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260125115956.GB1667597@robin.jannau.net>
Date: Sun, 25 Jan 2026 12:59:56 +0100
From: Janne Grunau <j@...nau.net>
To: Sven Peter <sven@...nel.org>
Cc: Neal Gompa <neal@...pa.dev>, Thomas Gleixner <tglx@...utronix.de>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, asahi@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] irqchip/apple-aic: Add support for "apple,t8122-aic3"

On Sun, Jan 25, 2026 at 12:42:38PM +0100, Sven Peter wrote:
> On 25.01.26 12:08, Janne Grunau wrote:
> > Introduce support for the new AICv3 hardware block in t8122 and t603x
> > SoCs. AICv3 is similar to AICv2 but has an increased IRQ config offset.
> > These MMIO offsets are coded as properties of the "aic,3" node in
> > Apple's device tree. The actual offsets are the same for all SoCs
> > starting from M3 through at least M5. So do not bother to follow suit
> > but use AICv3 specific defines in the driver.
> > The compatible string is SoC specific so future SoCs with AICv3 and
> > different offsets would just use their own compatible string as base and
> > add their new offsets.
> > 
> > Signed-off-by: Janne Grunau <j@...nau.net>
> > ---
> >   drivers/irqchip/irq-apple-aic.c | 27 +++++++++++++++++++++++++--
> >   1 file changed, 25 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c
> > index 3c70364e7cddd6ed6285595f136146ab04b897b2..f4efc325bebad1ae6119aa4eab47819a267da207 100644
> > --- a/drivers/irqchip/irq-apple-aic.c
> > +++ b/drivers/irqchip/irq-apple-aic.c
> > @@ -54,6 +54,7 @@
> >   #include <linux/irqdomain.h>
> >   #include <linux/jump_label.h>
> >   #include <linux/limits.h>
> > +#include <linux/of.h>
> 
> Did we miss this include previously or why is it added now?

It's a leftover from my initial (unsend) version which read MMIO offsets
from node properties.

It was strictly speaking missing though as the driver uses multiple
functions from it. On the other hand it is probably safe to assume that
of_address.h will include it implicity. I can remove this line from the
as it is confusing adding it without apparent reason.

Janne