linux-kernel - Re: [PATCH 2/2 RESEND] mailbox: Make mbox_send_message() return error code when tx fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABb+yY2ucPfFhDq3hK6UR3QmqyA+950vkDx0QFtJB+_Yzw66SQ@mail.gmail.com>
Date: Sat, 24 Jan 2026 19:51:56 -0600
From: Jassi Brar <jassisinghbrar@...il.com>
To: Joonwon Kang <joonwonkang@...gle.com>
Cc: linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 2/2 RESEND] mailbox: Make mbox_send_message() return error
 code when tx fails

On Tue, Dec 16, 2025 at 2:44 AM Joonwon Kang <joonwonkang@...gle.com> wrote:
>
> Previously, when the mailbox controller failed transmitting message, the
> error code was only passed to the client's tx done handler and not to
> mbox_send_message(). For this reason, the function could return a false
> success. This commit resolves the issue by introducing the tx status and
> checking it before mbox_send_message() returns.
>
A client submitted the message, and that client gets the actual
status. mbox_send_message does not (can not) tell if the message was
successfully sent or not. For example, consider non-blocking mode when
mbox_send_message() immediately returns after simply placing the
message in the fifo. It returns 0, but still the message transmission
may fail when its turn comes. So I think it is fine as is.
Thanks,
Jassi