linux-kernel - Re: [PATCH] media: chips-media: wave5: fix a potential memory leak in wave5_vdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026012518-carol-hankering-123d@gregkh>
Date: Sun, 25 Jan 2026 15:27:26 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
Cc: jackson.lee@...psnmedia.com, mchehab@...nel.org,
	bob.beckett@...labora.com, sebastian.fricke@...labora.com,
	dafna.hirschfeld@...labora.com, nicolas.dufresne@...labora.com,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH] media: chips-media: wave5: fix a potential memory leak
 in wave5_vdi_init()

On Sun, Jan 25, 2026 at 10:19:15PM +0800, Haoxiang Li wrote:
> Add wave5_vdi_free_dma_memory() in the error path of
> wave5_vdi_init() to prevent a potential memory leak.
> 
> Fixes: 45d1a2b93277 ("media: chips-media: wave5: Add vpuapi layer")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haoxiang Li <lihaoxiang@...c.iscas.ac.cn>
> ---
>  drivers/media/platform/chips-media/wave5/wave5-vdi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/platform/chips-media/wave5/wave5-vdi.c b/drivers/media/platform/chips-media/wave5/wave5-vdi.c
> index bb13267ced38..8f71920a8a35 100644
> --- a/drivers/media/platform/chips-media/wave5/wave5-vdi.c
> +++ b/drivers/media/platform/chips-media/wave5/wave5-vdi.c
> @@ -49,6 +49,7 @@ int wave5_vdi_init(struct device *dev)
>  
>  	if (!PRODUCT_CODE_W_SERIES(vpu_dev->product_code)) {
>  		WARN_ONCE(1, "unsupported product code: 0x%x\n", vpu_dev->product_code);
> +		wave5_vdi_free_dma_memory(vpu_dev, &vpu_dev->common_mem);
>  		return -EOPNOTSUPP;
>  	}
>  
> -- 
> 2.25.1
> 
> 

How was this found and tested?

thanks,

greg k-h