linux-kernel - Re: [PATCH net-next v2 1/3] net: phy: air

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <365006c0-8b44-46d5-8023-0912de0588f8@lunn.ch>
Date: Sun, 25 Jan 2026 17:23:26 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Bjørn Mork <bjorn@...k.no>
Cc: netdev@...r.kernel.org, "Lucien.Jheng" <lucienzx159@...il.com>,
	Daniel Golle <daniel@...rotopia.org>,
	Vladimir Oltean <vladimir.oltean@....com>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 1/3] net: phy: air_en8811h: factor out
 shareable code

On Sun, Jan 25, 2026 at 11:51:56AM +0100, Bjørn Mork wrote:
> Andrew Lunn <andrew@...n.ch> writes:
> 
> > Maybe a different strategy. Most of read_status is generic, it appears
> > just reading lpa is specific to the device. So have a generic
> > read_status() function, and then use phy_id_compare() to call the
> > needed device specific function.
> 
> Yes, maybe that's better.  My immediate feeling was that this
> contradicted your comments on the RFC

Reviewers sometimes get things wrong. It is not always possible to see
everything from just the patch, and then jump to the wrong conclusion,
etc. The review process should be a conversation. We can talk about
different solutions, which might contradict earlier suggestions, as we
get a better understanding of the problem to be solved.

   Andrew