linux-kernel - Re: [PATCH] tracing: Remove notrace from trace_event_raw_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8d8d91b883a8f0ed002bfec51f31f82ccbc8cd6a.camel@kernel.org>
Date: Sun, 25 Jan 2026 13:24:25 -0600
From: Tom Zanussi <zanussi@...nel.org>
To: Steven Rostedt <rostedt@...dmis.org>, LKML
 <linux-kernel@...r.kernel.org>,  Linux Trace Kernel
 <linux-trace-kernel@...r.kernel.org>
Cc: Masami Hiramatsu <mhiramat@...nel.org>, Mathieu Desnoyers
	 <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH] tracing: Remove notrace from
 trace_event_raw_event_synth()

Hi Steve,

On Thu, 2026-01-22 at 20:45 -0500, Steven Rostedt wrote:
> From: Steven Rostedt <rostedt@...dmis.org>
> 
> When debugging the synthetic events, being able to function trace its
> functions is very useful (now that CONFIG_FUNCTION_SELF_TRACING is
> available). For some reason trace_event_raw_event_synth() was marked as
> "notrace", which was totally unnecessary as all of the tracing directory
> had function tracing disabled until the recent FUNCTION_SELF_TRACING was
> added.
> 
> Remove the notrace annotation from trace_event_raw_event_synth() as
> there's no reason to not trace it when tracing synthetic event functions.
> 
> Signed-off-by: Steven Rostedt (Google) <rostedt@...dmis.org>

Acked-by: Tom Zanussi <zanussi@...nel.org>

Thanks,

Tom

> ---
>  kernel/trace/trace_events_synth.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/trace/trace_events_synth.c b/kernel/trace/trace_events_synth.c
> index 4554c458b78c..79a506fc2856 100644
> --- a/kernel/trace/trace_events_synth.c
> +++ b/kernel/trace/trace_events_synth.c
> @@ -493,9 +493,9 @@ static unsigned int trace_stack(struct synth_trace_event *entry,
>  	return len;
>  }
>  
> -static notrace void trace_event_raw_event_synth(void *__data,
> -						u64 *var_ref_vals,
> -						unsigned int *var_ref_idx)
> +static void trace_event_raw_event_synth(void *__data,
> +					u64 *var_ref_vals,
> +					unsigned int *var_ref_idx)
>  {
>  	unsigned int i, n_u64, val_idx, len, data_size = 0;
>  	struct trace_event_file *trace_file = __data;