linux-kernel - Re: [PATCH v2] rust: of: replace `core::mem::zeroed` with `pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72kgqJPwpW5QRg1Xg0d9Dbhe1RKxgpqmp_9vH0xopWO6eg@mail.gmail.com>
Date: Sun, 25 Jan 2026 20:28:42 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: moritz.zielke@...il.com, Benno Lossin <lossin@...nel.org>
Cc: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>, 
	Trevor Gross <tmgross@...ch.edu>, Danilo Krummrich <dakr@...nel.org>, devicetree@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rust: of: replace `core::mem::zeroed` with `pin_init::zeroed`

On Fri, Oct 31, 2025 at 10:52 AM Moritz Zielke via B4 Relay
<devnull+moritz.zielke.gmail.com@...nel.org> wrote:
>
> From: Moritz Zielke <moritz.zielke@...il.com>
>
> All types in `bindings` implement `Zeroable` if they can, so use
> `pin_init::zeroed` instead of relying on `unsafe` code.
>
> If this ends up not compiling in the future, something in bindgen or on
> the C side changed and is most likely incorrect.
>
> Link: https://github.com/Rust-for-Linux/linux/issues/1189
> Suggested-by: Benno Lossin <lossin@...nel.org>
> Signed-off-by: Moritz Zielke <moritz.zielke@...il.com>

These were also sent by Benno, and in the issue he mentions
"re-sending", which usually means just adding your Signed-off-by below
his:

    https://lore.kernel.org/all/20250814093046.2071971-1-lossin@kernel.org/

But he also mentioned the Suggested-by tag etc., so this is probably OK too.

Cheers,
Miguel