linux-kernel - Re: [net-next PatchV4 2/2] Octeontx2-pf: Add support for DMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260125142412.20b37981@kernel.org>
Date: Sun, 25 Jan 2026 14:24:12 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Hariprasad Kelam <hkelam@...vell.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <davem@...emloft.net>, <sgoutham@...vell.com>, <gakula@...vell.com>,
 <jerinj@...vell.com>, <lcherian@...vell.com>, <sbhatta@...vell.com>,
 <naveenm@...vell.com>, <edumazet@...gle.com>, <pabeni@...hat.com>,
 <andrew+netdev@...n.ch>, <bbhushan2@...vell.com>
Subject: Re: [net-next PatchV4 2/2] Octeontx2-pf: Add support for
 DMAC_FILTER trap

On Fri, 23 Jan 2026 16:17:31 +0530 Hariprasad Kelam wrote:
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
> @@ -3282,6 +3282,10 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	if (err)
>  		goto err_mcam_flow_del;
>  
> +	err = otx2_devlink_traps_register(pf);
> +	if (err)
> +		goto err_unregister_dl;
> +
>  	/* Initialize SR-IOV resources */
>  	err = otx2_sriov_vfcfg_init(pf);
>  	if (err)
> @@ -3314,6 +3318,8 @@ static int otx2_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	otx2_sriov_vfcfg_cleanup(pf);
>  err_pf_sriov_init:
>  	otx2_shutdown_tc(pf);
> +err_unregister_dl:
> +	otx2_unregister_dl(pf);

Hm, you're still not calling otx2_devlink_traps_unregister()
anywhere in this unwind ladder. If the missing otx2_unregister_dl()
is a pre-existing bug please send a separate fix (to net?) to address
that, and then this series on top.

>  err_mcam_flow_del:
>  	otx2_mcam_flow_del(pf);
>  err_unreg_netdev:
> @@ -3514,6 +3520,7 @@ static void otx2_remove(struct pci_dev *pdev)
>  	/* Disable link notifications */
>  	otx2_cgx_config_linkevents(pf, false);
>  
> +	otx2_devlink_traps_unregister(pf);
>  	otx2_unregister_dl(pf);
-- 
pw-bot: cr