linux-kernel - Re: [PATCH v5 1/7] staging: rtl8723bs: use continue statements to reduce indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMbZB6NtykT1WxJVLwoCZYt3rfvFz9Gjv-VGHog=azwjEe5mAA@mail.gmail.com>
Date: Sun, 25 Jan 2026 15:20:15 -0800
From: Te-Hsiu Huang <tehsiu.huang@...il.com>
To: Joe Perches <joe@...ches.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Dan Carpenter <dan.carpenter@...aro.org>, 
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/7] staging: rtl8723bs: use continue statements to
 reduce indentation

On Sun, Jan 25, 2026 at 10:13 AM Joe Perches <joe@...ches.com> wrote:

> Several additional things to consider for readability
>
> o Rename ICS to something more meaningful
> o Separate the ICS[x][0] uses to another named array [8]
> o Adding #defines for the array bounds 8 and 15 (or 14)
> o Change the loop bounds from 1 to 0 and 15 to 14
> o Converting this/these arrays to bool
> o Use boolean logic

Hi Joe,

Thanks for your valuable suggestions!!!

These points—especially renaming ICS, using #defines for array bounds,
and converting to boolean logic—would definitely improve the long-term
maintainability of this driver.

However, to keep this series focused on fixing the immediate
checkpatch warnings and reducing indentation as suggested by Dan,
would it be acceptable to handle these larger refactoring tasks in a
separate follow-up patch series?

I'd like to ensure the current cleanup (v5) is stable and correct
before introducing more significant structural changes to the logic.
Really appreciate your time!

Best regards,
Michael