linux-kernel - Re: [PATCH bpf-next v6 4/4] selftests/bpf: Add tests for signature verification kfuncs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQJQsC0cQZPJpyofY4Othi5+j7xjAY+xbNRkX0p9wA7Khg@mail.gmail.com>
Date: Sat, 24 Jan 2026 16:19:17 -0800
From: Alexei Starovoitov <alexei.starovoitov@...il.com>
To: Daniel Hodges <git@...ielhodges.dev>
Cc: bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>, 
	Andrii Nakryiko <andrii@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, 
	Vadim Fedorenko <vadim.fedorenko@...ux.dev>, Song Liu <song@...nel.org>, 
	Mykyta Yatsenko <yatsenko@...a.com>, Martin KaFai Lau <martin.lau@...ux.dev>, Eduard <eddyz87@...il.com>, 
	Hao Luo <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, 
	John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, 
	Stanislav Fomichev <sdf@...ichev.me>, Yonghong Song <yonghong.song@...ux.dev>, 
	Herbert Xu <herbert@...dor.apana.org.au>, "David S. Miller" <davem@...emloft.net>, 
	Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, 
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH bpf-next v6 4/4] selftests/bpf: Add tests for signature
 verification kfuncs

On Sat, Jan 24, 2026 at 9:44 AM Daniel Hodges <git@...ielhodges.dev> wrote:
>
> Add tests for the signature verification kfuncs:
>
> 1. test_ecdsa_verify_valid_signature: Verifies that a valid ECDSA
>    signature over a known message hash is correctly verified using
>    the P-256 curve with a test vector.
>
> 2. test_ecdsa_verify_invalid_signature: Verifies that an invalid
>    signature (with modified r component) is correctly rejected.
>
> 3. test_ecdsa_size_queries: Tests the bpf_sig_keysize(),
>    bpf_sig_digestsize(), and bpf_sig_maxsize() kfuncs to ensure
>    they return valid positive values for a P-256 ECDSA context.
>
> 4. test_ecdsa_on_hash_ctx: Tests that calling bpf_sig_verify on
>    a hash context fails with -EINVAL due to type mismatch.
>
> 5. test_ecdsa_keysize_on_hash_ctx: Tests that calling bpf_sig_keysize
>    on a hash context fails with -EINVAL due to type mismatch.
>
> 6. test_ecdsa_zero_len_msg: Tests that zero-length message is rejected.
>
> 7. test_ecdsa_zero_len_sig: Tests that zero-length signature is rejected.
>
> The test uses the p1363(ecdsa-nist-p256) algorithm with a known
> NIST P-256 test vector for reliable and reproducible testing.
>
> Signed-off-by: Daniel Hodges <git@...ielhodges.dev>
> ---
>  MAINTAINERS                                   |   2 +
>  .../selftests/bpf/prog_tests/sig_verify.c     | 163 ++++++++++
>  .../selftests/bpf/progs/crypto_common.h       |   6 +
>  .../testing/selftests/bpf/progs/sig_verify.c  | 286 ++++++++++++++++++
>  4 files changed, 457 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/prog_tests/sig_verify.c
>  create mode 100644 tools/testing/selftests/bpf/progs/sig_verify.c

It's a v6 already, but your new selftests are still failing in CI.

Error: #385 sig_verify
Error: #385/1 sig_verify/verify_valid_signature
Error: #385/3 sig_verify/size_queries
Error: #385/6 sig_verify/zero_len_msg
Error: #385/7 sig_verify/zero_len_sig

Please make sure CI is green before submitting v7.
No one is reviewing the patches when they don't pass their own tests.

pw-bot: cr