linux-kernel - Re: [PATCH] loongarch/kgdb: use IS_ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H6ffQ7zntWP16wRFP2gdd_RxBcBT0O==QKxOXVoHbiwtw@mail.gmail.com>
Date: Sun, 25 Jan 2026 12:07:47 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Carlos López <clopez@...e.de>
Cc: loongarch@...ts.linux.dev, WANG Xuerui <kernel@...0n.name>, 
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] loongarch/kgdb: use IS_ERR_PCPU() macro

Applied, thanks.

Huacai

On Thu, Jan 22, 2026 at 6:57 PM Carlos López <clopez@...e.de> wrote:
>
> In a759e37fb467 ("err.h: add ERR_PTR_PCPU(), PTR_ERR_PCPU() and
> IS_ERR_PCPU() macros"), specialized macros were added to check an error
> within a __percpu pointer, so use them instead of manually casting
> with __force, like all other users of register_wide_hw_breakpoint().
>
> Signed-off-by: Carlos López <clopez@...e.de>
> ---
>  arch/loongarch/kernel/kgdb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/loongarch/kernel/kgdb.c b/arch/loongarch/kernel/kgdb.c
> index 7be5b4c0c900..17664a6043b1 100644
> --- a/arch/loongarch/kernel/kgdb.c
> +++ b/arch/loongarch/kernel/kgdb.c
> @@ -697,7 +697,7 @@ void kgdb_arch_late(void)
>                         continue;
>
>                 breakinfo[i].pev = register_wide_hw_breakpoint(&attr, NULL, NULL);
> -               if (IS_ERR((void * __force)breakinfo[i].pev)) {
> +               if (IS_ERR_PCPU(breakinfo[i].pev)) {
>                         pr_err("kgdb: Could not allocate hw breakpoints.\n");
>                         breakinfo[i].pev = NULL;
>                         return;
>
> base-commit: a66191c590b3b58eaff05d2277971f854772bd5b
> --
> 2.51.0
>