linux-kernel - Re: [PATCH v2] bcache: fix I/O accounting leak in detached_dev_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aXeCGcsQ3XnwWaOK@infradead.org>
Date: Mon, 26 Jan 2026 07:02:49 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Coly Li <colyli@...as.com>
Cc: Christoph Hellwig <hch@...radead.org>, zhangshida2026@....com,
	kent.overstreet@...ux.dev, axboe@...nel.dk, osandov@...com,
	bvanassche@....org, linux-bcache@...r.kernel.org,
	linux-kernel@...r.kernel.org, zhangshida@...inos.cn,
	starzhangzsd@...il.com
Subject: Re: [PATCH v2] bcache: fix I/O accounting leak in
 detached_dev_do_request

On Mon, Jan 26, 2026 at 11:00:56PM +0800, Coly Li wrote:
> > I don't think that is correct.  This was just a trivial calling
> > convention change.
> > 
> 
> Hi Shida,
> 
> This Fixes tag is misleading. The correct to-be-fixed patch is commit
> 3ef825dfd4e4 ("bcache: use bio cloning for detached device requests")
> in linux-block/block-6.19 branch.

Not really.  The missing accounting was present before for the no-op
discard case.  See my reply for what I think is the culprit.