linux-kernel - Re: [PATCH 1/3] hwmon: spd5118: Do not fail resume on temporary I2C errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <adaff9d6-4539-49ed-af9b-932ac146bf6b@roeck-us.net>
Date: Mon, 26 Jan 2026 07:20:02 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Armin Wolf <W_Armin@....de>, TINSAE TADESSE <tinsaetadesse2015@...il.com>
Cc: "linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] hwmon: spd5118: Do not fail resume on temporary I2C
 errors

On 1/26/26 01:40, Armin Wolf wrote:
...
>>> Besides that: did the spd5118 driver load automatically on your device?
>>>
>>
>> I thought that was disabled. The i801 driver is supposed to detect if write
>> protect is enabled and, if so, it is supposed to not instantiate the spd5118
>> driver for DDR3. Support for this was added with commit 4d6d35d3417d ("i2c:
>> smbus: introduce Write Disable-aware SPD instantiating functions"). Apparently
>> the code to do this never made it into the i801 driver.
>>
>> The i801 driver needs to be fixed to inform the spd initialization code
>> that the spd5118 address range is write protected. The patch to do this was
>> "i2c: i801: Do not instantiate spd5118 under SPD Write Disable". I have no idea
>> why that patch didn't make it upstream.
>>
>> Guenter
>>
> Good question, do you want to send the message to the i2c maintainers about this
> or should i do it?
> 

Please go ahead. I am so far behind with everything :-(.

Thanks,
Guenter