[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAMRc=Mfdw=AVr1PzyJnG__qKCJ_GHMDTQuGDYkq=o4H7G+HMbw@mail.gmail.com>
Date: Mon, 26 Jan 2026 16:54:33 +0100
From: Bartosz Golaszewski <brgl@...nel.org>
To: Linus Walleij <linusw@...nel.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>,
Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>,
linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
linux-kernel@...r.kernel.org, Abel Vesa <abelvesa@...nel.org>, stable@...r.kernel.org,
Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Subject: Re: [PATCH] pinctrl: lpass-lpi: implement .get_direction() for the
GPIO driver
On Mon, Jan 26, 2026 at 3:41 PM Konrad Dybcio
<konrad.dybcio@....qualcomm.com> wrote:
>
> On 1/26/26 2:56 PM, Bartosz Golaszewski wrote:
> > GPIO controller driver should typically implement the .get_direction()
> > callback as GPIOLIB internals may try to use it to determine the state
> > of a pin. Add it for the LPASS LPI driver.
> >
> > Reported-by: Abel Vesa <abelvesa@...nel.org>
> > Cc: stable@...r.kernel.org
> > Fixes: 6e261d1090d6 ("pinctrl: qcom: Add sm8250 lpass lpi pinctrl driver")
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@....qualcomm.com>
> > ---
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> Tested-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com> # X1E CRD
>
Linus,
Just a heads-up: this is v6.19-rc8 material, as it got uncovered with
GPIO changes in rc6.
Thanks,
Bartosz
Powered by blists - more mailing lists