[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <88f97f6a-f8a8-441e-83eb-71415398b40a@zazolabs.com>
Date: Mon, 26 Jan 2026 17:56:05 +0200
From: Alexander Atanasov <alex@...olabs.com>
To: Ming Lei <ming.lei@...hat.com>
Cc: Shuah Khan <shuah@...nel.org>, linux-block@...r.kernel.org,
linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] selftests: ublk: mark each test start and end time in
dmesg
On 26.01.26 16:03, Ming Lei wrote:
> On Mon, Jan 26, 2026 at 11:25:44AM +0000, Alexander Atanasov wrote:
>> Log test start and end time in dmesg, so generated log messages
>> during the test run can be linked to specific test from the test
>> suite.
[snip]
>> _remove_test_files()
>> @@ -166,6 +167,7 @@ _cleanup_test() {
>> "${UBLK_PROG}" del -a
>>
>> _remove_files
>> + echo "ublk selftest: $TID done at $(date --iso-8601=sec)" | tee /dev/kmsg
>> }
>
> Also `date "+%F %T"`(which is taken by blktests project) looks more readable, such as:
>
> [root@...st-40 blktests]# date "+%F %T"
> 2026-01-26 14:00:51
> [root@...st-40 blktests]# date --iso-8601=sec
> 2026-01-26T14:01:54+00:00
>
> So would you like to consider it too?
I saw this a bit late. I choose iso-8601=sec since it is mid ground
between readable and reliable to parse. But if other test use +%F +%T
i'll cook a v3 with it, no point to deviate.
Powered by blists - more mailing lists