linux-kernel - Re: [PATCH v1] dt-bindings: input: Add TouchNetix aXiom touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <LOYP123MB270141B8B8CAC308B0D113C59793A@LOYP123MB2701.GBRP123.PROD.OUTLOOK.COM>
Date: Mon, 26 Jan 2026 16:28:03 +0000
From: Andrew Thomas <andrew.thomas@...chnetix.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "dmitry.torokhov@...il.com"
	<dmitry.torokhov@...il.com>
CC: "linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Mark
 Satterthwaite <mark.satterthwaite@...chnetix.com>, "m.felsch@...gutronix.de"
	<m.felsch@...gutronix.de>, "kamel.bouhara@...tlin.com"
	<kamel.bouhara@...tlin.com>
Subject: Re: [PATCH v1] dt-bindings: input: Add TouchNetix aXiom touchscreen
 driver

Hi Krzysztof,
Thank you for the quick review and giving me a lot to look into straight away!
I shall resubmit my patch correctly using b4 in a separate email.

> > + The TouchNetix aXiom series are high-performance touchscreen controllers
> > + supporting various interface methods including I2C and SPI.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - tnx,axiom-i2c
> > + - tnx,axiom-spi
> 
> No, these are the same. Use only one describing the device.
> 

Fixed.

> No device model? Really?

There are device models, but all devices use a very similar interface which
just changes with revision.

> > +allOf:
> > +  - $ref: touchscreen.yaml#
> 
> Missing ref to spi-periph.
> 
> Look at other bindings instead of inventing your own.

Added.

> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + axiom,poll-enable:
> 
> There is no such company as axiom. You just said it is tnx.
> 
> > + type: boolean
> > + description: Enable aXiom polling mode instead of interrupt-driven
> > + reporting.
> 
> Anyway, drop entire property. Not a DT suitable, not hardware.

Removed polling from device tree and added as a module_param.

Many Thanks,
Andrew