[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <DFYO7QI5YDJC.3EO91BDN01YBF@kernel.org>
Date: Mon, 26 Jan 2026 17:44:37 +0100
From: "Danilo Krummrich" <dakr@...nel.org>
To: "Boris Brezillon" <boris.brezillon@...labora.com>
Cc: "Alice Ryhl" <aliceryhl@...gle.com>, "Daniel Almeida"
<daniel.almeida@...labora.com>, "Janne Grunau" <j@...nau.net>, "Matthew
Brost" <matthew.brost@...el.com>, Thomas Hellström
<thomas.hellstrom@...ux.intel.com>, "Lyude Paul" <lyude@...hat.com>, "Asahi
Lina" <lina+kernel@...hilina.net>, <dri-devel@...ts.freedesktop.org>,
<linux-kernel@...r.kernel.org>, <rust-for-linux@...r.kernel.org>
Subject: Re: [PATCH v3 3/6] rust: gpuvm: add GpuVm::obtain()
On Mon Jan 26, 2026 at 4:35 PM CET, Boris Brezillon wrote:
> On Mon, 26 Jan 2026 16:07:30 +0100
> Alice Ryhl <aliceryhl@...gle.com> wrote:
>
>> On Mon, Jan 26, 2026 at 4:00 PM Boris Brezillon
>> <boris.brezillon@...labora.com> wrote:
>> >
>> > On Wed, 21 Jan 2026 11:31:19 +0000
>> > Alice Ryhl <aliceryhl@...gle.com> wrote:
>> >
>> > > +/// A [`GpuVmBo`] object in the GEM list.
>> > > +///
>> > > +/// # Invariants
>> > > +///
>> > > +/// Points at a `drm_gpuvm_bo` that contains a valid `T::VmBoData` and is present in the gem list.
>> > > +pub struct GpuVmBoResident<T: DriverGpuVm>(NonNull<GpuVmBo<T>>);
>> >
>> > I find the name a bit confusing: BO residency is often used to refer to
>> > memory backing the buffer object, and in this case, you can end up with
>> > a GpuVmBoResident being returned for a BO that has been evicted (one
>> > that's no longer resident).
>>
>> Good point. I meant it as "present in list" but I guess there are
>> other things a gpuvm may be present in.
>>
>> Any naming suggestions?
>
> Valid, Bound, Present, Active?
I still have to catch up on this series, but quick drive-by comment: I'd go for
'Registered'.
Powered by blists - more mailing lists