linux-kernel - Re: linux-next: build failure after merge of the net-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKf_4g=nT5YeVNbMBrLeXvhc6fJF9G_njoz=ZiqVfJYpQ@mail.gmail.com>
Date: Mon, 26 Jan 2026 18:32:45 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Mark Brown <broonie@...nel.org>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, Networking <netdev@...r.kernel.org>, 
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the net-next tree

On Mon, Jan 26, 2026 at 6:29 PM Mark Brown <broonie@...nel.org> wrote:
>
> Hi all,
>
> After merging the net-next tree, today's linux-next build (arm64
> defconfig) failed like this:
>
> /tmp/next/build/net/core/sysctl_net_core.c: In function 'proc_do_rss_key':
> /tmp/next/build/net/core/sysctl_net_core.c:333:23: error: implicit declaration of function 'hex_byte_pack' [-Wimplicit-function-declaration]
>   333 |                 pos = hex_byte_pack(pos, netdev_rss_key[i]);
>       |                       ^~~~~~~~~~~~~
> /tmp/next/build/net/core/sysctl_net_core.c:333:21: error: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
>   333 |                 pos = hex_byte_pack(pos, netdev_rss_key[i]);
>       |                     ^
>
> Caused by commit
>
>    37b0ea8fef56c (net: expand NETDEV_RSS_KEY_LEN to 256 bytes)
>
> I have used the tree from 20260123 instead.

I will send this fix then, thank you

diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
index 0f761d4b9447..03aea10073f0 100644
--- a/net/core/sysctl_net_core.c
+++ b/net/core/sysctl_net_core.c
@@ -17,6 +17,7 @@
 #include <linux/init.h>
 #include <linux/slab.h>
 #include <linux/sched/isolation.h>
+#include <linux/hex.h>

 #include <net/ip.h>
 #include <net/sock.h>