linux-kernel - Re: [PATCH v2 1/2] rust: kbuild: extract configs for reuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72kC58jdpyxx9AjVD-2cMHVWHAfbhZ1AYBu_MESsH1uYjg@mail.gmail.com>
Date: Mon, 26 Jan 2026 05:15:44 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Tamir Duberstein <tamird@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <lossin@...nel.org>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Jesung Yang <y.j3ms.n@...il.com>, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Nathan Chancellor <nathan@...nel.org>, 
	Nicolas Schier <nsc@...nel.org>, Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] rust: kbuild: extract configs for reuse

On Tue, Jan 20, 2026 at 5:10 PM Tamir Duberstein <tamird@...nel.org> wrote:
>
> Introduce `pin_init{,_internal}-{cfgs,flags}` and pass these new cfgs to
> `generate_rust_analyzer.py` to reduce duplicate information.
>
> Signed-off-by: Tamir Duberstein <tamird@...nel.org>

Looks good -- my suggestion was to move the two rust-analyzer lines
here (`--cfgs=`) also into the second patch, i.e. here it would just
be about factoring out the flags, and then in the second one you pass
them to `rust-analyzer` and use the information.

Doing it here doesn't hurt, since it will be unused on the script
side, so it is also fine, but I thought it would be more
understandable the other way around.

Anyway, I could perhaps take this one with or without the two lines,
and then next cycle you can apply to rust-analyzer the other one.

Thanks!

Cheers,
Miguel